Allow synchronous event dispatch #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelhoral
force-pushed
the
fix-event-dispatch
branch
from
e03187e
to
4d9517e
Compare
pavelhoral
force-pushed
the
fix-event-dispatch
branch
from
4d9517e
to
aa2f996
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables to have synchronous dispatch for event handlers defined via process configuration.
The previous
ProcessConfigurationcomponent had a strange race conditions when loading module dependencies that lead to out-of-order invocation of event handlers. This was apparent when showing and hiding loading spinner indicator.