Stop sounds when removing pawns #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iridar
changed the title
remove sounds and Cosmetic Pawns from units by updating ReleasePawnInternal
|
This generally looks like it should work, but it assumes the cosmetic unit comes from the secondary weapon slot. Do you think you can adjust the PR so it works regardless of slots? |
Iridar
added
waiting-on-author
|
Reworked this to loop over the attached units on the main pawn using its XCGS_Unit. Also updated the documentation to better fit HL-Docs formatting. |
Tedster59
added
ready-to-review
remove sounds and Cosmetic Pawns from units by updating ReleasePawnInternal Revise cosmetic pawn removal to not assume inventory slot Now loops over all cosmetic pawns on the associated UnitState instead of attempting to remove a pawn from the secondary slot. remove sounds and Cosmetic Pawns from units by updating ReleasePawnInternal Remove code for cosmetic pawn issue remove sounds and Cosmetic Pawns from units by updating ReleasePawnInternal Revise cosmetic pawn removal to not assume inventory slot Now loops over all cosmetic pawns on the associated UnitState instead of attempting to remove a pawn from the secondary slot. remove sounds and Cosmetic Pawns from units by updating ReleasePawnInternal Update UIPawnMgr.uc
Tedster59
changed the title
|
Updated PR name to only address the stop sounds part, going to move the cosmetic stuff to a separate fix. |
Iridar
added
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1192
Remove sounds by updating DestroyPawns to call StopSounds() and Cosmetic Pawns from units by updating ReleasePawnInternal to grab and also remove the Cosmetic Pawn. Addresses issue #1192 based on Rusty's code.