-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support deleted object in ledger_entry
#1306
Labels
Milestone
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Modifying the
ledger_entry
API as follows:New Request Parameter
include_deleted
objectNotFound
(current behavior) .New Response Parameter
deleted_ledger_index
Motivation
Currently,
ledger_entry
API returnsobjectNotFound
if the object has been deleted. But perhaps someone may want to find the object data before its deletion, without the need to dig through transaction history to find the index at which this particular object was deleted.I think clio can introduce an improved
ledger_entry
API with the a change - rather than returningobjectNotFound
for a deleted object, it would return the complete object data prior to its deletion, as well as an additional field to indicated the ledger index at which the object wad deleted.This is useful it for something like XRPL explorer. For example, if I create a MPT page that queries
ledger_entry
, it would work fine as long as the MPT is not destroyed. However, after the MPT is destroyed, the MPT page will no longer be available becauseledger_entry
will now returnobjectNotFound
. This would result in suboptimal experience in the explorer. This would improve the user experience on explorers in the long term, as explorer adds new page for each object type.The text was updated successfully, but these errors were encountered: