Add include_deleted param to ledger_entry API
#721
Conversation
…try-api Add include delete to ledger entry api
| @@ -264,6 +264,8 @@ class LedgerEntry(Request, LookupByLedgerRequest): | |||
| binary: bool = False | |||
| nft_page: Optional[str] = None | |||
| """Must be the object ID of the NFToken page, as hexadecimal""" | |||
| include_deleted: Optional[bool] = None | |||
| """This parameter is supported only by Clio servers""" | |||
There was a problem hiding this comment.
can you also add a link to the documentation reference for this include_deleted parameter?
There was a problem hiding this comment.
I couldn't find a mention of include_deleted in the XRPL docs: https://xrpl.org/docs/references/http-websocket-apis/public-api-methods/ledger-methods/ledger_entry/
There was a problem hiding this comment.
This one is still on progress (XRPLF/clio#1306) so it's not in XRPL docs for now. Do I need to add that link to ledger_entry.py?
There was a problem hiding this comment.
Hmm, I see. It would have been helpful to add the docs link, but it's not absolutely essential.
| @@ -264,6 +264,8 @@ class LedgerEntry(Request, LookupByLedgerRequest): | |||
| binary: bool = False | |||
| nft_page: Optional[str] = None | |||
| """Must be the object ID of the NFToken page, as hexadecimal""" | |||
| include_deleted: Optional[bool] = None | |||
There was a problem hiding this comment.
Why does the xrpl-py client library not contain the deleted_ledger_index parameter? I observed it in the javascript client library
There was a problem hiding this comment.
Since there's no response class in ledger_entry.py so I assume we don't need it? For js one there's already a response class(interface) so I just add deleted_ledger_index to that class.
High Level Overview of Change
Based on XRPLF/clio#1306
Context of Change
Type of Change
Did you update CHANGELOG.md?
Test Plan