Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove repeat words #5041

Merged
merged 2 commits into from
Jun 14, 2024
Merged

chore: remove repeat words #5041

merged 2 commits into from
Jun 14, 2024

Conversation

todaymoon
Copy link
Contributor

@todaymoon todaymoon commented Jun 9, 2024

High Level Overview of Change

Context of Change

remove repeat words

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Signed-off-by: todaymoon <csgcgl@foxmail.com>
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.3%. Comparing base (20d0549) to head (7e4c1dd).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5041   +/-   ##
=======================================
  Coverage     71.3%   71.3%           
=======================================
  Files          796     796           
  Lines        66900   66900           
  Branches     10870   10866    -4     
=======================================
+ Hits         47698   47706    +8     
+ Misses       19202   19194    -8     
Files Coverage Δ
src/ripple/app/paths/impl/Steps.h 93.1% <ø> (ø)
src/ripple/ledger/impl/ApplyView.cpp 69.9% <ø> (ø)
src/ripple/ledger/impl/PaymentSandbox.cpp 53.1% <ø> (ø)

... and 4 files with indirect coverage changes

Impacted file tree graph

@seelabs seelabs merged commit 3f5e321 into XRPLF:develop Jun 14, 2024
19 checks passed
ximinez added a commit to ximinez/rippled that referenced this pull request Jul 1, 2024
* upstream/develop: (32 commits)
  fixInnerObjTemplate2 amendment (XRPLF#5047)
  Set version to 2.3.0-b1
  Ignore restructuring commits (XRPLF#4997)
  Recompute loops (XRPLF#4997)
  Rewrite includes (XRPLF#4997)
  Rearrange sources (XRPLF#4997)
  Move CMake directory (XRPLF#4997)
  Add bin/physical.sh (XRPLF#4997)
  Prepare to rearrange sources: (XRPLF#4997)
  Change order of checks in amm_info: (XRPLF#4924)
  Add the fixEnforceNFTokenTrustline amendment: (XRPLF#4946)
  Replaces the usage of boost::string_view with std::string_view (XRPLF#4509)
  docs: explain how to find a clang-format patch generated by CI (XRPLF#4521)
  XLS-52d: NFTokenMintOffer (XRPLF#4845)
  chore: remove repeat words (XRPLF#5041)
  Expose all amendments known by libxrpl (XRPLF#5026)
  fixReducedOffersV2: prevent offers from blocking order books: (XRPLF#5032)
  Additional unit tests for testing deletion of trust lines (XRPLF#4886)
  Fix conan typo: (XRPLF#5044)
  Add new command line option to make replaying transactions easier: (XRPLF#5027)
  ...
vlntb pushed a commit to vlntb/rippled that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants