Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conan typo: #5044

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix conan typo: #5044

merged 1 commit into from
Jun 12, 2024

Conversation

oleks-rip
Copy link
Collaborator

High Level Overview of Change

Fixed typo in conanfile

Context of Change

Added missed coma in 'exports_sources'

Type of Change

  • [ x ] Bug fix (non-breaking change which fixes an issue)

Add missed coma in 'exportes_sources'
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.3%. Comparing base (d576416) to head (129ecd9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5044     +/-   ##
=========================================
- Coverage     71.3%   71.3%   -0.0%     
=========================================
  Files          796     796             
  Lines        66883   66883             
  Branches     10866   10870      +4     
=========================================
- Hits         47685   47677      -8     
- Misses       19198   19206      +8     

see 2 files with indirect coverage changes

Impacted file tree graph

@seelabs seelabs merged commit 58f3abe into XRPLF:develop Jun 12, 2024
19 checks passed
@oleks-rip oleks-rip deleted the conan_fix branch June 12, 2024 17:37
ximinez added a commit to ximinez/rippled that referenced this pull request Jul 1, 2024
* upstream/develop: (32 commits)
  fixInnerObjTemplate2 amendment (XRPLF#5047)
  Set version to 2.3.0-b1
  Ignore restructuring commits (XRPLF#4997)
  Recompute loops (XRPLF#4997)
  Rewrite includes (XRPLF#4997)
  Rearrange sources (XRPLF#4997)
  Move CMake directory (XRPLF#4997)
  Add bin/physical.sh (XRPLF#4997)
  Prepare to rearrange sources: (XRPLF#4997)
  Change order of checks in amm_info: (XRPLF#4924)
  Add the fixEnforceNFTokenTrustline amendment: (XRPLF#4946)
  Replaces the usage of boost::string_view with std::string_view (XRPLF#4509)
  docs: explain how to find a clang-format patch generated by CI (XRPLF#4521)
  XLS-52d: NFTokenMintOffer (XRPLF#4845)
  chore: remove repeat words (XRPLF#5041)
  Expose all amendments known by libxrpl (XRPLF#5026)
  fixReducedOffersV2: prevent offers from blocking order books: (XRPLF#5032)
  Additional unit tests for testing deletion of trust lines (XRPLF#4886)
  Fix conan typo: (XRPLF#5044)
  Add new command line option to make replaying transactions easier: (XRPLF#5027)
  ...
vlntb pushed a commit to vlntb/rippled that referenced this pull request Aug 23, 2024
Add missed coma in 'exportes_sources'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants