from_xrpl should not accept snake_case dict keys
#694
Conversation
Co-authored-by: Mayukha Vadari <mvadari@ripple.com>
|
The integration and snippet tests are not reliable. I'm observing these errors: (Integration Test Python 3.8): Snippet test error: httpx.HTTPStatusError: |
Co-authored-by: Mayukha Vadari <mvadari@ripple.com>
|
@justinr1234 @khancode can you please review this at your convinience? |
| # Note: BaseModel.from_xrpl and its overridden methods accept only camelCase or | ||
| # PascalCase inputs (i.e. snake_case is not accepted) | ||
| def test_from_xrpl_accepts_only_camel_case_inputs(self): | ||
| request = { |
There was a problem hiding this comment.
What's the difference between this test case and tx_snake_case_keys? Just want to make sure I'm following what's going on here :)
There was a problem hiding this comment.
Hello, both the tests dis-allow snake_case keys in Request and Transaction models, respectively. I used different inputs for two different models
There was a problem hiding this comment.
Could you split it into 2 tests (2 functions)?
|
I have updated the regular-expression which is used to invalidate inputs in If anyone has objections pertaining to it, please let me know. It is not related to the changelist of this PR. |
* BaseModel.from_xrpl method should not accept snake_case keys in dictionary input * Fix integration test: Update regex to accomodate Amount2 AMM field --------- Co-authored-by: Mayukha Vadari <mvadari@ripple.com>
BaseModel.from_xrplmethod should not accept snake_case keys in dictionary input.Fix #689 . You can find more context in the discussion pertaining to this issue.
I have used a regular expression matches for snake_case. If you have any other ideas for detecting
non-camelCaseinput formats, let me know. There appears to be a variety of solutions for this problem, but all of them have slight differences in their behavior.High Level Overview of Change
Context of Change
Type of Change
Did you update CHANGELOG.md?
Do external users use
from_xrplmethod? I believe they usefrom_dict(hasn't been modified) which internally makes a call tofrom_xrplTest Plan