Skip to content

Commit

Permalink
cleanup: remove dupe tests, update lock and docs (#2505)
Browse files Browse the repository at this point in the history
- Remove tests from `ripple-keypairs` that exclusively tested
`rippled-address-codec`. The tests in `codec.test.ts` and
`xrp-codec.test.ts` are all present and accounted for in
`packages/ripple-address-codec/test/xrp-codec.test.ts`.
- Update `package-lock.json` after the rebase with main
- Remove references to `decimal.js` in the documentation
* add missing entry for `bignumber.js` to `ripple-binary-codec`

This will clean up the diff for #2273
  • Loading branch information
ckniffen committed Oct 18, 2023
1 parent c39e8cf commit 711c12f
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 159 deletions.
2 changes: 2 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/ripple-binary-codec/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
},
"dependencies": {
"buffer": "6.0.3",
"bignumber.js": "^9.0.0",
"create-hash": "^1.2.0",
"ripple-address-codec": "^4.3.1"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/ripple-binary-codec/src/types/amount.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const MIN_XRP = new BigNumber('1e-6')
const mask = BigInt(0x00000000ffffffff)

/**
* decimal.js configuration for Amount IOUs
* BigNumber configuration for Amount IOUs
*/
BigNumber.config({
EXPONENTIAL_AT: [
Expand Down Expand Up @@ -207,7 +207,7 @@ class Amount extends SerializedType {
/**
* Validate IOU.value amount
*
* @param decimal Decimal.js object representing IOU.value
* @param decimal BigNumber object representing IOU.value
* @returns void, but will throw if invalid amount
*/
private static assertIouIsValid(decimal: BigNumber): void {
Expand Down
58 changes: 0 additions & 58 deletions packages/ripple-keypairs/test/codec.test.ts

This file was deleted.

99 changes: 0 additions & 99 deletions packages/ripple-keypairs/test/xrp-codec.test.ts

This file was deleted.

0 comments on commit 711c12f

Please sign in to comment.