cleanup: remove dupe tests, update lock and docs #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove tests from `ripple-keypairs` that exclusively tested `rippled-address-codec`. The tests in `codec.test.ts` and `xrp-codec.test.ts` are all present and accounted for in `packages/ripple-address-codec/test/xrp-codec.test.ts`. - Update `package-lock.json` after the rebase with main - Remove references to `decimal.js` in the documentation This will clean up the diff for #2273
32 tasks
mvadari
approved these changes
Oct 6, 2023
jonathanlei
approved these changes
Oct 6, 2023
ckniffen
added a commit
that referenced
this pull request
Oct 18, 2023
- Remove tests from `ripple-keypairs` that exclusively tested `rippled-address-codec`. The tests in `codec.test.ts` and `xrp-codec.test.ts` are all present and accounted for in `packages/ripple-address-codec/test/xrp-codec.test.ts`. - Update `package-lock.json` after the rebase with main - Remove references to `decimal.js` in the documentation * add missing entry for `bignumber.js` to `ripple-binary-codec` This will clean up the diff for #2273
ckniffen
added a commit
that referenced
this pull request
Oct 25, 2023
- Remove tests from `ripple-keypairs` that exclusively tested `rippled-address-codec`. The tests in `codec.test.ts` and `xrp-codec.test.ts` are all present and accounted for in `packages/ripple-address-codec/test/xrp-codec.test.ts`. - Update `package-lock.json` after the rebase with main - Remove references to `decimal.js` in the documentation * add missing entry for `bignumber.js` to `ripple-binary-codec` This will clean up the diff for #2273
ckniffen
added a commit
that referenced
this pull request
Nov 1, 2023
- Remove tests from `ripple-keypairs` that exclusively tested `rippled-address-codec`. The tests in `codec.test.ts` and `xrp-codec.test.ts` are all present and accounted for in `packages/ripple-address-codec/test/xrp-codec.test.ts`. - Update `package-lock.json` after the rebase with main - Remove references to `decimal.js` in the documentation * add missing entry for `bignumber.js` to `ripple-binary-codec` This will clean up the diff for #2273
ckniffen
added a commit
that referenced
this pull request
Nov 30, 2023
- Remove tests from `ripple-keypairs` that exclusively tested `rippled-address-codec`. The tests in `codec.test.ts` and `xrp-codec.test.ts` are all present and accounted for in `packages/ripple-address-codec/test/xrp-codec.test.ts`. - Update `package-lock.json` after the rebase with main - Remove references to `decimal.js` in the documentation * add missing entry for `bignumber.js` to `ripple-binary-codec` This will clean up the diff for #2273
ckniffen
added a commit
that referenced
this pull request
Feb 1, 2024
- Remove tests from `ripple-keypairs` that exclusively tested `rippled-address-codec`. The tests in `codec.test.ts` and `xrp-codec.test.ts` are all present and accounted for in `packages/ripple-address-codec/test/xrp-codec.test.ts`. - Update `package-lock.json` after the rebase with main - Remove references to `decimal.js` in the documentation * add missing entry for `bignumber.js` to `ripple-binary-codec` This will clean up the diff for #2273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
ripple-keypairsthat exclusively testedrippled-address-codec. The tests incodec.test.tsandxrp-codec.test.tsare all present and accounted for inpackages/ripple-address-codec/test/xrp-codec.test.ts.package-lock.jsonafter the rebase with maindecimal.jsin the documentationThis will clean up the diff for #2273
Type of Change
Did you update HISTORY.md?