cleanup: remove dupe tests, update lock and docs (#2505)

- Remove tests from `ripple-keypairs` that exclusively tested `rippled-address-codec`. The tests in `codec.test.ts` and `xrp-codec.test.ts` are all present and accounted for in `packages/ripple-address-codec/test/xrp-codec.test.ts`. - Update `package-lock.json` after the rebase with main - Remove references to `decimal.js` in the documentation * add missing entry for `bignumber.js` to `ripple-binary-codec` This will clean up the diff for #2273
XRPLF · Oct 25, 2023 · fdbe150 · fdbe150
1 parent 38bafba
commit fdbe150
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 159 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/ripple-binary-codec/package.json b/packages/ripple-binary-codec/package.json
@@ -12,6 +12,7 @@
  },
  "dependencies": {
  "buffer": "6.0.3",
+ "bignumber.js": "^9.0.0",
  "create-hash": "^1.2.0",
  "ripple-address-codec": "^4.3.1"
  },

diff --git a/packages/ripple-binary-codec/src/types/amount.ts b/packages/ripple-binary-codec/src/types/amount.ts
@@ -17,7 +17,7 @@ const MIN_XRP = new BigNumber('1e-6')
 const mask = BigInt(0x00000000ffffffff)
 
 /**
- * decimal.js configuration for Amount IOUs
+ * BigNumber configuration for Amount IOUs
  */
 BigNumber.config({
  EXPONENTIAL_AT: [
@@ -207,7 +207,7 @@ class Amount extends SerializedType {
  /**
  * Validate IOU.value amount
  *
- * @param decimal Decimal.js object representing IOU.value
+ * @param decimal BigNumber object representing IOU.value
  * @returns void, but will throw if invalid amount
  */
  private static assertIouIsValid(decimal: BigNumber): void {

diff --git a/packages/ripple-keypairs/test/codec.test.ts b/packages/ripple-keypairs/test/codec.test.ts
diff --git a/packages/ripple-keypairs/test/xrp-codec.test.ts b/packages/ripple-keypairs/test/xrp-codec.test.ts