feat: add sidechain-specific RPCs/sugar #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JST5000
reviewed
Mar 17, 2022
| * | ||
| * @category Responses | ||
| */ | ||
| export interface FederatorInfoResponse extends BaseResponse { |
There was a problem hiding this comment.
Should these values have docstrings/comments explaining what they are used for like we do with other requests?
There was a problem hiding this comment.
Yes - however, those don't exist yet.
JST5000
reviewed
Mar 17, 2022
| * @throws XrplError - if there are more than 2 memos. | ||
| * @category Utilities | ||
| */ | ||
| export default function createXchainPayment( |
There was a problem hiding this comment.
Naming wise I think it's better to explicitly write "Cross" rather than "X" since X is actually meaningful sometimes in our libraries (Ex. xAddress)
Also, "chain" should be capitalized.
I'd recommend to rename this function to createCrossChainPayment
There was a problem hiding this comment.
I agree. Let's use "Cross" instead to avoid ambiguity.
JST5000
reviewed
Mar 17, 2022
khancode
approved these changes
Mar 21, 2022
| * @throws XrplError - if there are more than 2 memos. | ||
| * @category Utilities | ||
| */ | ||
| export default function createXchainPayment( |
There was a problem hiding this comment.
I agree. Let's use "Cross" instead to avoid ambiguity.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR:
federator_inforequest and response objectsContext of Change
xrpl.js sidechain support
Type of Change
Before / After
Test Plan
Added tests for the helper method. I'm not sure how to test the RPC call and object, since standalone rippled isn't a federator. CI passes.