remove: remove old sidechain design features #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckniffen
approved these changes
Aug 4, 2022
mvadari
force-pushed
the
remove-old-sidechains
branch
from
ca7256a
to
1143e26
Compare
mvadari
changed the title
khancode
approved these changes
Aug 30, 2022
mvadari
force-pushed
the
remove-old-sidechains
branch
from
1143e26
to
e3335dd
Compare
mvadari
force-pushed
the
remove-old-sidechains
branch
from
e3335dd
to
d2b7717
Compare
mvadari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR essentially reverses #1940. It removes all the features related to the old sidechain design.
This PR will not be merged until #2039 is ready.
Context of Change
These are no longer necessary for the new sidechain design.
Type of Change
While this is technically a breaking change, it's removing support for a feature that never existed in production rippled, so we don't need a major version bump.
Test Plan
CI passes.