feat: remove 3 http related polyfills #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate the need to specify polyfills for `url`, `http`, and `https`. Future commits will add a dependency of node-fetch for running in node which will be handled transparently and in a backward compatible way. Another large benefit is this substantially simplifies `fundWallet.ts`
jonathanlei
reviewed
Jul 12, 2023
jonathanlei
reviewed
Jul 12, 2023
# Conflicts: # package-lock.json # packages/xrpl/src/Wallet/fundWallet.ts # packages/xrpl/src/index.ts
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
FYI I added branch protections for 3.0 (same ones that apply to main) |
JST5000
reviewed
Jul 17, 2023
JST5000
reviewed
Jul 17, 2023
|
|
||
| // eslint-disable-next-line @typescript-eslint/consistent-type-assertions -- Its a FaucetWallet | ||
| const body = (await response.json()) as FaucetWallet | ||
| // "application/json; charset=utf-8" |
There was a problem hiding this comment.
I dont think so but it was left over.
ckniffen
changed the title
Co-authored-by: Jackson Mills <jmills@ripple.com>
jonathanlei
approved these changes
Jul 26, 2023
ckniffen
added a commit
that referenced
this pull request
Aug 12, 2023
Switch to using fetch for browser and `node-fetch` for node for the faucet calls. This reduces the webpack bundle by 3.2% or 16.5kb gzipped. The fundWallet code has been refactored to be much more straight forward due to not having to do such low level operations. This improves the frontend setup process by no longer requiring several polyfills such as `url`, `stream-http`, and `https-browserify`.
ckniffen
added a commit
that referenced
this pull request
Aug 15, 2023
Switch to using fetch for browser and `node-fetch` for node for the faucet calls. This reduces the webpack bundle by 3.2% or 16.5kb gzipped. The fundWallet code has been refactored to be much more straight forward due to not having to do such low level operations. This improves the frontend setup process by no longer requiring several polyfills such as `url`, `stream-http`, and `https-browserify`.
ckniffen
added a commit
that referenced
this pull request
Aug 28, 2023
Switch to using fetch for browser and `node-fetch` for node for the faucet calls. This reduces the webpack bundle by 3.2% or 16.5kb gzipped. The fundWallet code has been refactored to be much more straight forward due to not having to do such low level operations. This improves the frontend setup process by no longer requiring several polyfills such as `url`, `stream-http`, and `https-browserify`.
ckniffen
added a commit
that referenced
this pull request
Aug 28, 2023
Switch to using fetch for browser and `node-fetch` for node for the faucet calls. This reduces the webpack bundle by 3.2% or 16.5kb gzipped. The fundWallet code has been refactored to be much more straight forward due to not having to do such low level operations. This improves the frontend setup process by no longer requiring several polyfills such as `url`, `stream-http`, and `https-browserify`.
ckniffen
added a commit
that referenced
this pull request
Sep 1, 2023
Switch to using fetch for browser and `node-fetch` for node for the faucet calls. This reduces the webpack bundle by 3.2% or 16.5kb gzipped. The fundWallet code has been refactored to be much more straight forward due to not having to do such low level operations. This improves the frontend setup process by no longer requiring several polyfills such as `url`, `stream-http`, and `https-browserify`.
ckniffen
added a commit
that referenced
this pull request
Oct 5, 2023
Switch to using fetch for browser and `node-fetch` for node for the faucet calls. This reduces the webpack bundle by 3.2% or 16.5kb gzipped. The fundWallet code has been refactored to be much more straight forward due to not having to do such low level operations. This improves the frontend setup process by no longer requiring several polyfills such as `url`, `stream-http`, and `https-browserify`.
ckniffen
added a commit
that referenced
this pull request
Oct 18, 2023
Switch to using fetch for browser and `node-fetch` for node for the faucet calls. This reduces the webpack bundle by 3.2% or 16.5kb gzipped. The fundWallet code has been refactored to be much more straight forward due to not having to do such low level operations. This improves the frontend setup process by no longer requiring several polyfills such as `url`, `stream-http`, and `https-browserify`.
ckniffen
added a commit
that referenced
this pull request
Oct 25, 2023
Switch to using fetch for browser and `node-fetch` for node for the faucet calls. This reduces the webpack bundle by 3.2% or 16.5kb gzipped. The fundWallet code has been refactored to be much more straight forward due to not having to do such low level operations. This improves the frontend setup process by no longer requiring several polyfills such as `url`, `stream-http`, and `https-browserify`.
ckniffen
added a commit
that referenced
this pull request
Nov 1, 2023
Switch to using fetch for browser and `node-fetch` for node for the faucet calls. This reduces the webpack bundle by 3.2% or 16.5kb gzipped. The fundWallet code has been refactored to be much more straight forward due to not having to do such low level operations. This improves the frontend setup process by no longer requiring several polyfills such as `url`, `stream-http`, and `https-browserify`.
ckniffen
added a commit
that referenced
this pull request
Nov 30, 2023
Switch to using fetch for browser and `node-fetch` for node for the faucet calls. This reduces the webpack bundle by 3.2% or 16.5kb gzipped. The fundWallet code has been refactored to be much more straight forward due to not having to do such low level operations. This improves the frontend setup process by no longer requiring several polyfills such as `url`, `stream-http`, and `https-browserify`.
ckniffen
added a commit
that referenced
this pull request
Feb 1, 2024
Switch to using fetch for browser and `node-fetch` for node for the faucet calls. This reduces the webpack bundle by 3.2% or 16.5kb gzipped. The fundWallet code has been refactored to be much more straight forward due to not having to do such low level operations. This improves the frontend setup process by no longer requiring several polyfills such as `url`, `stream-http`, and `https-browserify`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Switch to using fetch for browser and
node-fetchfor node for the faucet calls. This reduces the webpack bundle by 3.2% or 16.5kb gzipped.The fundWallet code has been refactored to be much more straight forward due to not having to do such low level operations.
This improves the frontend setup process by no longer requiring several polyfills such as
url,stream-http, andhttps-browserify.Context of Change
Type of Change
Test Plan
Some new tests might need to be added to validate error checking.