Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove 3 http related polyfills #2375

Merged
merged 12 commits into from
Jul 26, 2023
Merged

feat: remove 3 http related polyfills #2375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9c13789
feat: remove http related browser polyfills
ckniffen Jun 3, 2023
9140a4d
Use cross-fetch. This removes ~16.5kb from the fronend build
ckniffen Jul 12, 2023
c79ae53
fix analyze command.
ckniffen Jul 12, 2023
e6a40a9
add usageContext param and export FundingOptions type
ckniffen Jul 17, 2023
8427c18
Merge branch 'main' into feature/remove-https-browserify
ckniffen Jul 17, 2023
c5a6cb1
fix compilation and extra polyfill.
ckniffen Jul 17, 2023
b50d858
fixed tests
ckniffen Jul 17, 2023
832fe39
Fix typing
ckniffen Jul 17, 2023
2d6c64a
promise types can be tricky
ckniffen Jul 17, 2023
c491121
Add back userAgent to fundWallet
ckniffen Jul 17, 2023
43e625c
Merge branch '3.0' into feature/remove-https-browserify
ckniffen Jul 26, 2023
d9e0897
Apply nit suggestions from code review
ckniffen Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions UNIQUE_SETUPS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,8 @@ To use `xrpl.js` with React, you need to install shims for core NodeJS modules.
assert \
buffer \
crypto-browserify \
https-browserify \
os-browserify \
process \
stream-browserify \
stream-http \
url
stream-browserify
```

2. Modify your webpack configuration
Expand All @@ -48,11 +44,7 @@ To use `xrpl.js` with React, you need to install shims for core NodeJS modules.
Object.assign(fallback, {
assert: require.resolve("assert"),
crypto: require.resolve("crypto-browserify"),
http: require.resolve("stream-http"),
https: require.resolve("https-browserify"),
os: require.resolve("os-browserify"),
stream: require.resolve("stream-browserify"),
url: require.resolve("url"),
ws: require.resolve("xrpl/dist/npm/client/WSWrapper"),
});
config.resolve.fallback = fallback;
Expand Down Expand Up @@ -141,7 +133,6 @@ export default defineConfig({
},
optimizeDeps: {
esbuildOptions: {

define: {
global: 'globalThis',
},
Expand All @@ -165,8 +156,6 @@ resolve: {
events: 'events',
crypto: 'crypto-browserify',
stream: 'stream-browserify',
http: 'stream-http',
https: 'https-browserify',
ws: 'xrpl/dist/npm/client/WSWrapper',
},
}})
Expand All @@ -181,8 +170,6 @@ npm install --save-dev @esbuild-plugins/node-globals-polyfill \
events \
crypto-browserify \
stream-browserify \
stream-http \
https-browserify \
xrpl
```

Expand Down
76 changes: 53 additions & 23 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
"eslint-plugin-tsdoc": "^0.2.16",
"eventemitter2": "^6.0.0",
"expect": "^29.3.1",
"https-browserify": "^1.0.0",
"jest": "^29.3.1",
"jest-mock": "^29.3.1",
"lerna": "^4.0.0",
Expand All @@ -60,12 +59,10 @@
"source-map-loader": "^4.0.1",
"source-map-support": "^0.5.16",
"stream-browserify": "^3.0.0",
"stream-http": "3.2.0",
"ts-jest": "^29.0.3",
"ts-loader": "^9.2.5",
"ts-node": "^10.2.1",
"typescript": "^5.1.6",
"url": "^0.11.0",
"webpack": "^5.81.0",
"webpack-bundle-analyzer": "^4.1.0",
"webpack-cli": "^5.0.1"
Expand Down
1 change: 1 addition & 0 deletions packages/xrpl/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"bignumber.js": "^9.0.0",
"bip32": "^2.0.6",
"bip39": "^3.0.4",
"cross-fetch": "^4.0.0",
"ripple-address-codec": "^4.3.0",
"ripple-binary-codec": "^1.7.1",
"ripple-keypairs": "^1.3.0",
Expand Down
Loading