-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
passive transformation #249
Conversation
…ction which includes displacement@
it seems to include all the commits from PR 248, is there some nice way for me to make these go away since that PR has been approved? |
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 1289 1294 +5
=========================================
+ Hits 1289 1294 +5
Continue to review full report at Codecov.
|
Co-authored-by: Nicolas Quesada <nicolas@xanadu.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this 👍
Mostly, I just have docstring nitpicks. It seems like a lot of comments, but it's mostly just some minor rephrasing and style.
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
thanks for the review @albi3ro !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @jakebulmer ! Thanks for the review @albi3ro !
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
new function
passive_transformation
which allows for a Gaussian state to be transformed by a non-unitary, non-square passive linear optical transformation.also generalised the
squeezing
function to allow for the symplectic transformation of multiple modes of single mode squeezing to be generated.(also includes changelog update for previous PR)