Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passive transformation #249

Merged
merged 40 commits into from
Jun 22, 2021
Merged

passive transformation #249

merged 40 commits into from
Jun 22, 2021

Conversation

jakeffbulmer
Copy link
Contributor

@jakeffbulmer jakeffbulmer commented Jun 18, 2021

new function passive_transformation which allows for a Gaussian state to be transformed by a non-unitary, non-square passive linear optical transformation.

also generalised the squeezing function to allow for the symplectic transformation of multiple modes of single mode squeezing to be generated.

(also includes changelog update for previous PR)

@jakeffbulmer
Copy link
Contributor Author

it seems to include all the commits from PR 248, is there some nice way for me to make these go away since that PR has been approved?

thewalrus/symplectic.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #249 (cf81781) into master (355b8ff) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #249   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1289      1294    +5     
=========================================
+ Hits          1289      1294    +5     
Impacted Files Coverage Δ
thewalrus/symplectic.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 355b8ff...cf81781. Read the comment docs.

@jakeffbulmer jakeffbulmer changed the title Lin transf passive transformation Jun 18, 2021
@nquesada nquesada requested a review from antalszava June 18, 2021 17:32
.github/CHANGELOG.md Outdated Show resolved Hide resolved
@nquesada nquesada requested review from albi3ro and removed request for antalszava June 18, 2021 17:47
thewalrus/symplectic.py Outdated Show resolved Hide resolved
thewalrus/symplectic.py Outdated Show resolved Hide resolved
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 👍

Mostly, I just have docstring nitpicks. It seems like a lot of comments, but it's mostly just some minor rephrasing and style.

thewalrus/symplectic.py Show resolved Hide resolved
thewalrus/symplectic.py Outdated Show resolved Hide resolved
thewalrus/symplectic.py Outdated Show resolved Hide resolved
thewalrus/symplectic.py Outdated Show resolved Hide resolved
thewalrus/symplectic.py Outdated Show resolved Hide resolved
thewalrus/symplectic.py Outdated Show resolved Hide resolved
thewalrus/symplectic.py Outdated Show resolved Hide resolved
thewalrus/symplectic.py Outdated Show resolved Hide resolved
thewalrus/tests/test_symplectic.py Show resolved Hide resolved
thewalrus/tests/test_symplectic.py Show resolved Hide resolved
nquesada and others added 13 commits June 22, 2021 12:12
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
@jakeffbulmer
Copy link
Contributor Author

thanks for the review @albi3ro !!

Copy link
Collaborator

@nquesada nquesada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @jakebulmer ! Thanks for the review @albi3ro !

Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
thewalrus/symplectic.py Outdated Show resolved Hide resolved
@nquesada nquesada merged commit e32c40a into XanaduAI:master Jun 22, 2021
@jakeffbulmer jakeffbulmer deleted the lin_transf branch June 23, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants