Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

related to 'Click here to edit' in script.js #104

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

prem-k-r
Copy link
Contributor

@prem-k-r prem-k-r commented Oct 22, 2024

  1. Remove placeholder text when the user starts editing
  2. Restore placeholder if the user leaves the div empty after editing
  3. weather tweak: Saving IP address in local storage to minimize errors (rare case). When the user hasn’t entered a location, the code first tries to fetch the IP from ipinfo.io. If that fails or is unavailable, it retrieves the previously stored IP address from local storage to ensure smooth functionality without interrupting the weather data retrieval.

1. Remove placeholder text when the user starts editing
2. Restore placeholder if the user leaves the div empty after editing
3. weather tweak: Saving IP address in local storage to minimize errors
@prem-k-r
Copy link
Contributor Author

now, no need to select all and delete it. it automatically removed when clicked
https://github.com/user-attachments/assets/e0dd790b-8d4b-4e0b-8c53-e8067e3699f0

Copy link
Contributor

@itz-rj-here itz-rj-here left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really a great work

@XengShi XengShi merged commit e7c9ef5 into XengShi:main Oct 22, 2024
@prem-k-r prem-k-r deleted the patch-10 branch October 23, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants