Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather Display issue when weatherTextCondition is long #97

Closed
prem-k-r opened this issue Oct 21, 2024 · 10 comments
Closed

Weather Display issue when weatherTextCondition is long #97

prem-k-r opened this issue Oct 21, 2024 · 10 comments

Comments

@prem-k-r
Copy link
Collaborator

image
image

btw, for me weatherAPI always fetch wrong location from IPv4 address. Reason why I use manual inputted location. 😅

@XengShi
Copy link
Owner

XengShi commented Oct 22, 2024

Screenshot from 2024-10-22 21-03-58

After changing the language getting Undefined location and empty Feels like temp

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Oct 22, 2024

@XengShi please merge #86 to fix it

@prem-k-r
Copy link
Collaborator Author

@XengShi, also could you please check and merge the other functional PRs at your convenience?

#104: script.js file (languages.js and index.js have already been merged)

#98 and #99: Czech date formatting

And display PR #89 (confirm if this view is acceptable)

Also, PR #93 is good to go.
Thanks

@XengShi
Copy link
Owner

XengShi commented Oct 22, 2024

Everything seems perfect now.
@prem12321kumar Bhai bahut achha kaam kiya hai aapne, tomorrow I will release it

@prem-k-r
Copy link
Collaborator Author

Thanks a lot! I am learning a lot with all of this.

@XengShi
Copy link
Owner

XengShi commented Oct 22, 2024

Hey, what do you think about translating the greeting messages (like Good Morning, Good Evening, etc.) into regional languages? Since you've already worked on similar tasks, I understand it may not offer much in terms of learning something new. If you're interested, feel free to work on it only when you have some free time!

@prem-k-r
Copy link
Collaborator Author

Hey, what do you think about translating the greeting messages (like Good Morning, Good Evening, etc.) into regional languages? Since you've already worked on similar tasks, I understand it may not offer much in terms of learning something new. If you're interested, feel free to work on it only when you have some free time!

Actually, I did try it, but there was bugs. I put it on hold and planned to try again later.
I was also working on translating numerals in some languages like Bengali, and fallback to English if the translation was missing for any particular language. None of it was working properly. Maybe in comming weeks or so, if I can correct it and not solved by anyone else till then, I'll raise a request for a pull merge.

@prem-k-r
Copy link
Collaborator Author

I was checking my fork to ensure everything was fine and found some unwanted things
image
This alert should be translated as well or not, not sure. Thoughts?

image
In Bangla this translation is bit longer, should we translate it to just নিজের প্রক্সি হোস্ট করুন (Host your proxy) instead of 'Host your own proxy'?

and the change I did in userText to remove placeholder text when the user starts editing and restore placeholder if the user leaves it empty after clicking, It works for English only as placeholder text "Click here to edit" is hardcoded in the focus and blur event listeners.

@itz-rj-here
Copy link
Collaborator

In Bangla this translation is bit longer, should we translate it to just নিজের প্রক্সি হোস্ট করুন (Host your proxy) instead of 'Host your own proxy'?

and the change I did in userText to remove placeholder text when the user starts editing and restore placeholder if the user leaves it empty after clicking, It works for English only as placeholder text "Click here to edit" is hardcoded in the focus and blur event listeners.

You are good to go with that. It should be নিজের প্রক্সি হোস্ট করুন.

@prem-k-r
Copy link
Collaborator Author

Hey, what do you think about translating the greeting messages (like Good Morning, Good Evening, etc.) into regional languages? Since you've already worked on similar tasks, I understand it may not offer much in terms of learning something new. If you're interested, feel free to work on it only when you have some free time!

finally done. lol the issue was in index.html, reordered language.js and script.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants