Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added right padding in 'feelsLike' to proper display in some languages #89

Closed
wants to merge 1 commit into from

Conversation

prem-k-r
Copy link
Collaborator

added padding to Seems
image
changed to
image

added padding in Seems
@ceskyDJ
Copy link
Contributor

ceskyDJ commented Oct 21, 2024

It looks way better, but there is one other thing — a space missing between the number and its unit (correct is e.g. 27 °C). I don't know how it should be elsewhere, but in Czech there had to be an (unbreakable) space between them.

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Oct 21, 2024

And over another thing… We use decimal commas instead of decimal dots, so, e.g., "9,1 °C" is correct.

@itz-rj-here
Copy link
Collaborator

@prem12321kumar

@prem-k-r
Copy link
Collaborator Author

that's a bit complicated, have a rough idea, might or might not work, will try later.

for now in Czech formatting can change displayed date format (Mon, Oct 21) only.

@prem-k-r
Copy link
Collaborator Author

@ceskyDJ
image

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Oct 25, 2024

Oh, there is another mistake I didn't see before. There has to be a space between number and ° in temperature. This brings me to one question: Shouldn't we print °C, resp. °F there? Degree is an unit of angle… Anyway, a space is missing in both cases for Czech.

@prem-k-r
Copy link
Collaborator Author

Oh, there is another mistake I didn't see before. There has to be a space between number and ° in temperature. This brings me to one question: Shouldn't we print °C, resp. °F there? Degree is an unit of angle… Anyway, a space is missing in both cases for Czech.

I totally understand and agree with your point. The correct units are indeed °C and °F, as "degree" shouldn’t stand alone. However, adding "C" or "F" will result in a longer display, which is why I initially left it as it was, just the numbers with the degree symbol and without the degree symbol, it looks odd to me.

Maybe later I can try adjusting the format, like displaying 21^(°C or °F in a smaller font)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants