Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Update Czech according to last changes of original strings #124

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

ceskyDJ
Copy link
Contributor

@ceskyDJ ceskyDJ commented Nov 1, 2024

No description provided.

@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Nov 1, 2024

I have one note here. @prem12321kumar did this change:

- "userLoc": "Your location (City/Latitude,Longitude)",
+ "userLoc": "Your location (City or Latitude,Longitude)",

If I update Czech according to this change, it'll be a complete mess so that nobody can understand it properly:

- "userLoc": "Vaše poloha (město / zeměpisná šířka, zeměpisná délka)",
+ "userLoc": "Vaše poloha (město nebo zeměpisná šířka, zeměpisná délka)",

I think the best solution for this is to make it more clear in all languages, something like:

English
- "userLoc": "Your location (City or Latitude,Longitude)",
+ "userLoc": "Your location — city or geocoordinates (e.g., `50.09118602632995,14.401595046959825`)",

Czech
- "userLoc": "Vaše poloha (město nebo zeměpisná šířka, zeměpisná délka)",
+ "userLoc": "Vaše poloha – město nebo zeměpisné souřadnice (např. `50.09118602632995,14.401595046959825`)",

Of course, we may not need such precision here. I just copied the coordinates from Google Maps.

@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Nov 1, 2024

There is another way (maybe better?):

English
- "userLoc": "Your location (City or Latitude,Longitude)",
+ "userLoc": "Your location — city or geocoordinates (in form: latitude,longitude)",

Czech
- "userLoc": "Vaše poloha (město nebo zeměpisná šířka, zeměpisná délka)",
+ "userLoc": "Vaše poloha – město nebo zeměpisné souřadnice (ve tvaru: šířka,délka)",

@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Nov 1, 2024

I just noticed another thing about the digital clock. What about this change?

English
- "digitalclockinfo": "Enable the digital clock",
+ "digitalclockinfo": "Switch to the digital clock",

Czech
- "digitalclockinfo": "Zapne digitální hodiny",
+ "digitalclockinfo": "Přepne hodiny na digitální",

@prem-k-r
Copy link
Collaborator

prem-k-r commented Nov 1, 2024

I just noticed another thing about the digital clock. What about this change?

English
- "digitalclockinfo": "Enable the digital clock",
+ "digitalclockinfo": "Switch to the digital clock",

Czech
- "digitalclockinfo": "Zapne digitální hodiny",
+ "digitalclockinfo": "Přepne hodiny na digitální",

Yeah better.
You can change, I think.

@prem-k-r
Copy link
Collaborator

prem-k-r commented Nov 1, 2024

For location we have to check if it's fit in visible area.
I suggest:

Your City or GeoCoordinates (Lat,Long)

or
Your City or GeoCoordinates (Latitude,Longitude)
if it's visible

@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Nov 1, 2024

Ok, for Czech, this fits the input: Město nebo souřadnice (šířka,délka). English equivalent: Your City or Coordinates (Latitude,Longitude) (also fits).

@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Nov 1, 2024

For location we have to check if it's fit in visible area.

By the way, the current Czech translation doesn't fit the input (so it needs to be solved somehow).

@prem-k-r
Copy link
Collaborator

prem-k-r commented Nov 1, 2024

Ok, for Czech, this fits the input: Město nebo souřadnice (šířka,délka). English equivalent: Your City or Coordinates (Latitude,Longitude) (also fits).

Nice, Change it

@XengShi XengShi merged commit 3a794c6 into XengShi:main Nov 1, 2024
@ceskyDJ ceskyDJ deleted the update-czech branch November 1, 2024 16:39
@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Nov 1, 2024

Nice, Change it

@XengShi was a bit faster :D. I opened PR #125 for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants