This repository has been archived by the owner on May 10, 2022. It is now read-only.
add security #19
Draft
add security #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinzuoyan
approved these changes
Sep 26, 2018
vagetablechicken
force-pushed
the
thrift-0.11.0-inlined
branch
2 times, most recently
from
7ce43e5
to
215cd26
Compare
shengofsun
reviewed
Nov 21, 2018
| new TextCallbackHandler()); | ||
| } catch (LoginException le) { | ||
| logger.error("cannot create LoginContext. LoginException: {}", le.getMessage()); | ||
| System.exit(-1); |
There was a problem hiding this comment.
客户端开启认证，但是没法建立loginContext，我是认为它没有进行的必要了。有什么好的处理方法吗？
shengofsun
reviewed
Nov 21, 2018
src/main/java/com/xiaomi/infra/pegasus/rpc/async/TableHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/rpc/async/TableHandler.java
Outdated
Show resolved
Hide resolved
vagetablechicken
force-pushed
the
thrift-0.11.0-inlined
branch
from
0e7ca09
to
1688909
Compare
…a-client into security
vagetablechicken
force-pushed
the
thrift-0.11.0-inlined
branch
2 times, most recently
from
c189112
to
4be6f68
Compare
|
有些其他PR的修改, XiaoMi:security 分支rebase一下主干分支? |
要合入身份认证功能的时候也要更新代码和测试，所以我就打算到时候再合 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.