Feat: functionalize QuantTensor #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giuseppe5
force-pushed
the
torch_function_support
branch
4 times, most recently
from
f32ecaf
to
0176483
Compare
Giuseppe5
force-pushed
the
torch_function_support
branch
4 times, most recently
from
c6f5216
to
368d0a3
Compare
Giuseppe5
force-pushed
the
torch_function_support
branch
5 times, most recently
from
d84ad1f
to
dbdb7e3
Compare
Giuseppe5
commented
Mar 28, 2024
Giuseppe5
commented
Mar 28, 2024
Giuseppe5
commented
Mar 28, 2024
Giuseppe5
commented
Mar 28, 2024
Giuseppe5
commented
Mar 28, 2024
| bit_width=output_bit_width, | ||
| signed=output_signed, | ||
| training=output_training) | ||
| else: |
There was a problem hiding this comment.
@nickfraser I would like your opinion here
Giuseppe5
commented
Mar 28, 2024
Giuseppe5
force-pushed
the
torch_function_support
branch
2 times, most recently
from
40ea5b4
to
1365296
Compare
Giuseppe5
commented
Apr 16, 2024
Giuseppe5
commented
Apr 16, 2024
|
Remove all max_acc_bit_width implementations from brevitas/nn |
|
Once your above changes have been done, this LGTM |
nickfraser
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
#839,#880,#847,#883Outstanding layers:
HadamardClassifier-> Left for another PRQuantRNN and QuantLSTM(this might be challenging to abstract considering that we deal with proxys directly) -> Delayed indefinitely