New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: remove quant metadata from quantlayer #883

Merged

Giuseppe5 merged 3 commits into Xilinx:dev from Giuseppe5:move_caching

Mar 28, 2024

Collaborator

Giuseppe5 commented Feb 27, 2024 •

edited

Loading

Quant layer should not expose any attribute of their underlying proxys (e.g, quant_output_scale in QuantLayer).

Similarly, caching should be delegated to Proxy.

Missing tasks:

Remove comments
Armonize interface (is_signed vs signed())
Move caching all the way down to proxy (including flags to enable/disable caching)

As task for another PR, we should programmatically generate all the methods that were removed in this PR, such as layer.weight_quant_scale(). The Proxy should expose which methods the layer can pick up, and then generate that using proxy suffix + name of the method.

Giuseppe5 self-assigned this

Giuseppe5 commented

View reviewed changes

src/brevitas/proxy/parameter_quant.py Show resolved Hide resolved

Giuseppe5 force-pushed the move_caching branch from 16ac867 to 8622e1f Compare

February 28, 2024 10:40

Giuseppe5 commented

View reviewed changes

src/brevitas/nn/mixin/act.py Outdated Show resolved Hide resolved

Giuseppe5 commented

View reviewed changes

src/brevitas/nn/mixin/parameter.py Outdated Show resolved Hide resolved

Giuseppe5 commented

View reviewed changes

src/brevitas/nn/quant_layer.py Outdated Show resolved Hide resolved

Giuseppe5 commented

View reviewed changes

src/brevitas/proxy/parameter_quant.py Outdated Show resolved Hide resolved

Giuseppe5 force-pushed the move_caching branch from a8900a0 to f5cc575 Compare

February 28, 2024 12:51

Giuseppe5 mentioned this pull request

Feat: functionalize QuantTensor #878

Merged

4 tasks

Giuseppe5 force-pushed the move_caching branch 2 times, most recently from 57f66b1 to a36d65f Compare

March 5, 2024 08:37

Giuseppe5 commented

View reviewed changes

src/brevitas/export/common/handler/base.py Outdated Show resolved Hide resolved

Giuseppe5 commented

View reviewed changes

src/brevitas/nn/quant_layer.py Outdated Show resolved Hide resolved

Giuseppe5 commented

View reviewed changes

src/brevitas/export/common/handler/base.py Outdated Show resolved Hide resolved

Giuseppe5 commented

View reviewed changes

src/brevitas/export/torch/qoperator/handler/parameter.py Outdated Show resolved Hide resolved

Giuseppe5 force-pushed the move_caching branch 2 times, most recently from 6077380 to 8849800 Compare

March 6, 2024 22:28

Giuseppe5 commented

View reviewed changes

src/brevitas_examples/super_resolution/utils/evaluate.py Outdated Show resolved Hide resolved

Giuseppe5 requested review from nickfraser and removed request for nickfraser

March 7, 2024 12:03

Giuseppe5 force-pushed the move_caching branch 2 times, most recently from bbf4cc4 to 95df101 Compare

March 14, 2024 00:37

Giuseppe5 requested review from nickfraser and costigt-dev

March 26, 2024 11:08

costigt-dev approved these changes

View reviewed changes

Collaborator

costigt-dev left a comment

looks good, the changes like quant_weight_scale to quant_weight.scale are nice

Giuseppe5 requested review from nickfraser and removed request for nickfraser

March 27, 2024 07:51

Giuseppe5 force-pushed the move_caching branch from de45c86 to e684bfd Compare

March 27, 2024 08:08

Giuseppe5 requested review from nickfraser and removed request for nickfraser

March 27, 2024 08:52


Feat: remove quant metadata from quantlayer

a021f2b

Giuseppe5 force-pushed the move_caching branch from 129336b to a021f2b Compare

March 27, 2024 14:33

Fix

nickfraser approved these changes

View reviewed changes

Collaborator

nickfraser left a comment

LGTM!

Giuseppe5 commented

View reviewed changes

src/brevitas/export/common/handler/base.py Outdated Show resolved Hide resolved


Remove unused methods

2a3e7c1

Giuseppe5 requested a review from nickfraser

March 28, 2024 10:16

Giuseppe5 merged commit e1da07b into Xilinx:dev

346 of 347 checks passed

Giuseppe5 deleted the move_caching branch

March 28, 2024 12:29

Giuseppe5 added a commit to Giuseppe5/brevitas that referenced this pull request


Feat!: remove quant metadata from quantlayer (Xilinx#883)

dc2779b

Breaking change: The interface to access quant metadata has changed and now everything is directly delegated to the underlying proxies.

Giuseppe5 added a commit to Giuseppe5/brevitas that referenced this pull request


Feat!: remove quant metadata from quantlayer (Xilinx#883)

Breaking change: The interface to access quant metadata has changed and now everything is directly delegated to the underlying proxies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment