[AIE2] Enable libc++ support #142
Conversation
konstantinschwarz
requested review from
abhinay-anubola,
abnikant,
andcarminati,
gbossu,
khallouh,
martien-de-jong,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
konstantinschwarz
force-pushed
the
kschwarz.libcxx.libc.support
branch
2 times, most recently
from
9b7fc90 to
ed42f43
Compare
|
Cool :) |
|
|
||
| // We don't ship libc/libcxx for AIE1 | ||
| if (getTriple().isAIE1()) | ||
| return; |
There was a problem hiding this comment.
Does this actually fail, or have you just not tried it?
There was a problem hiding this comment.
I haven't tried it
| @@ -8,7 +8,7 @@ | |||
| // (c) Copyright 2023-2024 Advanced Micro Devices, Inc. or its affiliates | |||
| // | |||
| //===----------------------------------------------------------------------===// | |||
| // RUN: %clang --target=aie2 -S -emit-llvm %s -o - | FileCheck %s | |||
| // RUN: %clang --target=aie2 -nostdlibinc -S -emit-llvm %s -o - | FileCheck %s | |||
There was a problem hiding this comment.
I'm a bit concerned at having to sprinkle this everywhere. Is this just because these tests might need to run without the runtimes having been built?
There was a problem hiding this comment.
Yes this is needed because we call the %clang driver here instead of -cc1. That expects the runtimes to be present, which we cannot rely on in clang codegen tests.
Applications will not have to set this option
konstantinschwarz
force-pushed
the
kschwarz.libcxx.libc.support
branch
from
ed42f43 to
c6edd43
Compare
|
Tested this using mlir-aie and a PR from @stephenneuendorffer. I verified on hardware using this passthrough kernel (after removing unnecessary |
For now this only "builds" the __config_site headers and installs the header-only library. More compiler support is needed to build the library components. This also enables more libc headers that are required by libcxx.
This matches the type in the low level intrinsic spec
…ted yet This allows us to compile kernels using AIE_API abstractions while bringing up complete support for the intrinsic API.
konstantinschwarz
force-pushed
the
kschwarz.libcxx.libc.support
branch
from
c6edd43 to
84de106
Compare
This PR does three things: