Update peano linker script generation #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was possible for some input sections to not get properly copied to our executable. Fix the linker script and enable more error checking during linking to ensure this doesn't happen.
jgmelber
reviewed
Aug 23, 2024
|
This, unfortunately, didn't fix my "first run mismatch" error using Peano to compile the passthrough example C++ kernel code. |
|
I was using this PR for Peano: Xilinx/llvm-aie#142 |
jgmelber
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Tested this works for compiling a C++ kernel without AIE API using Peano PR: Xilinx/llvm-aie#142
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible for some input sections to not get properly copied to our executable. Fix the linker script and enable more error checking during linking to ensure this doesn't happen.