Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have AIECtrlPacketToDmaPass create dynamic MemRefType for ctrl packet stream #1776

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Have AIECtrlPacketToDmaPass create dynamic MemRefType for ctrl packet stream #1776

merged 4 commits into from
Sep 18, 2024

Conversation

erwei-xilinx
Copy link
Collaborator

…instead of hard coded.

@erwei-xilinx erwei-xilinx mentioned this pull request Sep 18, 2024
Merged
@erwei-xilinx erwei-xilinx marked this pull request as ready for review September 18, 2024 19:07
@fifield
Copy link
Collaborator

fifield commented Sep 18, 2024

…instead of hard coded.

Could it also be <?xi32>? Does the size even matter since the length of transfer is encoded in the memcpy_nd?

@erwei-xilinx
Copy link
Collaborator Author

erwei-xilinx commented Sep 18, 2024 •
edited
Loading

…instead of hard coded.

Could it also be <?xi32>? Does the size even matter since the length of transfer is encoded in the memcpy_nd?

Good point. Yeah it should work. PR updated. I also modified the verifier for AIEX::NpuDmaMemcpyOp slightly just to unblock dynamic shaped memrefs, but I don't think the memcpy op fundamentally requires the memref to be static.

@erwei-xilinx erwei-xilinx changed the title Have AIECtrlPacketToDmaPass figure out the ctrl packet stream size Have AIECtrlPacketToDmaPass create dynamic MemRefType for ctrl packet stream Sep 18, 2024
@erwei-xilinx erwei-xilinx added this pull request to the merge queue Sep 18, 2024
@erwei-xilinx erwei-xilinx mentioned this pull request Sep 18, 2024
Merged
Merged via the queue into Xilinx:main with commit d0d6ba7 Sep 18, 2024
67 checks passed
@erwei-xilinx erwei-xilinx deleted the ctrlpkt_to_dma_get_packet_stream_size branch September 18, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenneuendorffer stephenneuendorffer Awaiting requested review from stephenneuendorffer stephenneuendorffer is a code owner

@jgmelber jgmelber Awaiting requested review from jgmelber jgmelber is a code owner

@fifield fifield Awaiting requested review from fifield fifield is a code owner

@jackl-xilinx jackl-xilinx Awaiting requested review from jackl-xilinx jackl-xilinx is a code owner

@AndraBisca AndraBisca Awaiting requested review from AndraBisca AndraBisca is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erwei-xilinx @fifield