Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨Create custom and triangle link animation #134

Merged
merged 1 commit into from
Mar 30, 2022
Merged

🎨Create custom and triangle link animation #134

merged 1 commit into from
Mar 30, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Mar 30, 2022 •
edited
Loading

Description

This will create custom links animation for triangle and non-triangle(custom) ports.

Custom link

  1. Unselected : Gray line
  2. Selected : Yellow stroke-dashoffset

Triangle link

  1. Unselected : Blue stroke-dashoffset
  2. Selected : Yellow line

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Try the 4 line conditions mentioned above.
  2. Connect the links as usual and run xircuits.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@AdrySky AdrySky added the enhancement New feature or request label Mar 30, 2022
@AdrySky AdrySky requested a review from MFA-X-AI March 30, 2022 03:16
@AdrySky AdrySky self-assigned this Mar 30, 2022
MFA-X-AI
MFA-X-AI approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glorious.

shiny

Thanks for the PR, works on my end. Merging~

@MFA-X-AI MFA-X-AI merged commit 33e6627 into master Mar 30, 2022
@MFA-X-AI MFA-X-AI deleted the adry/custom-link-animation branch March 30, 2022 06:41
@MFA-X-AI MFA-X-AI mentioned this pull request Apr 9, 2023
Closed
16 tasks
@MFA-X-AI MFA-X-AI mentioned this pull request May 17, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MFA-X-AI MFA-X-AI MFA-X-AI approved these changes

Assignees

@AdrySky AdrySky

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdrySky @MFA-X-AI