Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔗 Reduce Resource Consumption for Link Animation #250

Merged
merged 2 commits into from
May 19, 2023
Merged

🔗 Reduce Resource Consumption for Link Animation #250

merged 2 commits into from
May 19, 2023

Conversation

MFA-X-AI
Copy link
Member

@MFA-X-AI MFA-X-AI commented May 17, 2023 •
edited
Loading

Description

The current canvas renders link animation in 60 fps, which builds up the resource consumption if you have lots of those. This PR limits it to 24 fps.

Before:
image
16.6ms for every new frame

Now:
image
30ms ~ 50 ms

References

#134

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

Test the resource consumption before and after using this PR's wheel.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@MFA-X-AI MFA-X-AI merged commit 362d095 into master May 19, 2023
@MFA-X-AI MFA-X-AI deleted the update-fps branch May 19, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treo treo treo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MFA-X-AI @treo