Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Truncate long strings #190

Merged
merged 1 commit into from
Aug 22, 2022
Merged

🎨 Truncate long strings #190

merged 1 commit into from
Aug 22, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Aug 18, 2022 •
edited
Loading

Description

This will truncated any long text. Max characters per line is 80.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Add Literal String
  2. Insert a long one-line string (more than 80 characters)
  3. You will see it'll not overflow
  4. Also, it'll render an ellipsis ("...") to represent the clipped text.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@AdrySky AdrySky added the bug Something isn't working label Aug 18, 2022
@AdrySky AdrySky requested a review from MFA-X-AI August 18, 2022 06:44
@AdrySky AdrySky self-assigned this Aug 18, 2022
MFA-X-AI
MFA-X-AI approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I've tested it on my windows, looks pretty solid. The truncate length is perfect so the SQL strings aren't cut out.
image
Can confirm that it also properly codegens.
image
Great work, merging~

@MFA-X-AI MFA-X-AI merged commit 664bebc into master Aug 22, 2022
@MFA-X-AI MFA-X-AI deleted the adry/truncate-long-str branch August 22, 2022 03:45
@MFA-X-AI MFA-X-AI changed the title 🐛Truncate long strings 🎨 Truncate long strings Aug 22, 2022
@MFA-X-AI MFA-X-AI mentioned this pull request Apr 6, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MFA-X-AI MFA-X-AI MFA-X-AI approved these changes

Assignees

@AdrySky AdrySky

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdrySky @MFA-X-AI