Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Long String Overflow Display #229

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Update Long String Overflow Display #229

merged 1 commit into from
Apr 6, 2023

Conversation

MFA-X-AI
Copy link
Member

@MFA-X-AI MFA-X-AI commented Apr 6, 2023 •
edited
Loading

Description

Updates long string display to overflow. Currently the limit is set to be 40ch.
For reference, this is how it looks currently, for 40ch and for 80ch.

Previous:
image

40ch
image

80ch
image

References

#190

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Drag in a string component. Give it a long text, maybe from here. Rate the aesthetic quality.
  2. Run the workflow. Ensure that it can perform its function correctly.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

mansouralawi
mansouralawi approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@mansouralawi mansouralawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It works as expected.

@mansouralawi
Copy link
Member

Maybe we could add a scroll bar for the literal string component in future

@mansouralawi mansouralawi merged commit 951ee1f into master Apr 6, 2023
@mansouralawi mansouralawi deleted the fahreza/update-overflow branch April 6, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansouralawi mansouralawi mansouralawi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MFA-X-AI @mansouralawi