🐛 Fix Components Not Refreshing on Reload from Canvas #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#293 implemented refactoring of the code fetching for components and the reload mechanism by implementing a cache for the component library code. However, this cache is currently only updated when the component tray button is pressed. This PR ensure that the cache is also refreshed when the "Reload Node" option is used from the right-click context menu or the "Reload All Nodes" option is selected from the toolbar.
References
#293
Pull Request Type
Type of Change
Tests
Drag in a component. Update a port. Trigger reload by
Reload NodeandReload All Nodes. Verify that it correctly updates.Tested on?
Notes
Add if any.