Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix Components Not Refreshing on Reload from Canvas #318

Merged
merged 1 commit into from
Apr 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/XircuitsBodyWidget.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -685,9 +685,9 @@ export const BodyWidget: FC<BodyWidgetProps> = ({
return;
}

await app.commands.execute(commandIDs.refreshComponentList);
let allNodes = xircuitsApp.getDiagramEngine().getModel().getNodes();
allNodes.forEach(node => node.setSelected(true));

const reloadPromise = app.commands.execute(commandIDs.reloadNode);

// Trigger loading animation
Expand Down
1 change: 1 addition & 0 deletions src/context-menu/CanvasContextMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export class CanvasContextMenu extends React.Component<CanvasContextMenuProps> {
let visibility = getMenuOptionsVisibility(models);

const handleReloadNode = async () => {
await this.props.app.commands.execute(commandIDs.refreshComponentList);
let loadPromise = await this.props.app.commands.execute(commandIDs.reloadNode);
await this.props.app.commands.execute(commandIDs.triggerLoadingAnimation, { loadPromise,
loadingMessage: 'Reloading node...', loadingDisplayDuration: 10000, showLoadingAfter: 10
Expand Down
Loading