Adding HTTPS on Prod version #214

RichtXO · 2020-10-04T00:21:15Z

Features Added

I added certs and open both port 80 and 443. Port 80 will redirect to port 443. Also made it auto-generate the OpenSSL certificate every time it reruns.

Additional Info

https://tech.osteel.me/posts/docker-for-local-web-development-part-5-https-all-the-things#generating-the-certificate
https://www.digitalocean.com/community/tutorials/how-to-create-a-self-signed-ssl-certificate-for-nginx-in-ubuntu-16-04

Added certs and open both port 80 and 443. Port 80 will redirect to port 443.

github-actions · 2020-10-04T00:22:37Z

Deploy Link: http://45.33.71.174/
Branch and Build Info: http://45.33.71.174:3000/info.txt
Expected Time Ready: Sat Oct 3 20:32:27 EDT 2020

123joshuawu · 2020-10-04T02:10:31Z

The autogenerating openssl is cool

Seems like the redirect is redirecting to localhost:443 which isn't working on the pr-deploy

Also, just wondering, how would we specify custom ssl certificates?

RichtXO · 2020-10-04T17:16:29Z

Oh, that's weird... I'll double-check with my end on this.
Just wondering, did you open 443 for the thing that generates the deploy link?

123joshuawu · 2020-10-04T18:07:07Z

Ah I did not, only the :80 to :443 redirect

RichtXO · 2020-10-04T18:39:13Z

Wait, what does that mean?

123joshuawu · 2020-10-04T19:34:19Z

So the issue is the pr-deploy is not overriding the $HOST env var for the web container so it defaults to localhost. Thus when you go to port 80, it returns a 301 redirect to https://localhost:443 which fails

RichtXO · 2020-10-04T21:12:27Z

So now said that's a deployment issue? Nothing wrong with the code. It's just that this deployment thing isn't (like you said) not overriding.

123joshuawu · 2020-10-05T00:32:02Z

Yes, unfortunately we'll need to fix that before we merge or its going to break on subsequent pull requests. tagging @jshom re: the pr-cd workflow

github-actions · 2020-10-06T21:17:04Z

Deploy Link: http://173.255.231.178/
Branch and Build Info: http://173.255.231.178:3000/info.txt
Expected Time Ready: Tue Oct 6 17:26:54 EDT 2020

Added certs and open both port 80 and 443. Port 80 will redirect to port 443.

github-actions · 2020-10-06T21:23:51Z

Deploy Link: /
Branch and Build Info: :3000/info.txt
Expected Time Ready: Tue Oct 6 17:33:39 EDT 2020

jshom · 2020-10-06T21:28:39Z

Niiiiiiiiiice! Good stuff man! 🎊

Two small tweaks to get this to work with our temp and other environments:

PR-CD can be fixed by going around redirects through providing link in github as HTTPS instead of HTTP in https://github.com/YACS-RCOS/yacs.n/blob/master/ops/provision.js#L73
Link certificates through docker volume for prod deploy and other environments, if these exist, use existing instead of self-signed certificate

github-actions · 2020-10-06T21:42:41Z

Deploy Link: https://23.239.14.246/
Branch and Build Info: https://23.239.14.246:3000/info.txt
Expected Time Ready: Tue Oct 6 17:52:31 EDT 2020

Added certs and open both port 80 and 443. Port 80 will redirect to port 443.

jshom · 2020-10-06T21:52:18Z

oi, the build info link... this is fine for now, will make another issue for this, no need to fix it in this PR (this would need to stick to http)

RichtXO · 2020-10-06T21:57:18Z

Yeah. But this is weird. I think 3 days ago, I couldn't get into port 443 on the old URL: 45.33.71.174. I typed the URL with the HTTPS and didn't go through. It may have been my cookies.

jshom · 2020-10-06T22:02:59Z

Yeah. But this is weird. I think 3 days ago, I couldn't get into port 443 on the old URL: 45.33.71.174. I typed the URL with the HTTPS and didn't go through. It may have been my cookies.

Ye maybe, I think that could have been a flaky build too.

github-actions · 2020-10-09T21:21:36Z

Deploy Link: http://45.79.183.91/
Branch and Build Info: http://45.79.183.91:3000/info.txt
Expected Time Ready: Fri Oct 9 17:31:27 EDT 2020

github-actions · 2020-10-14T15:10:15Z

Deploy Link: https://45.79.171.4/
Branch and Build Info: https://45.79.171.4:3000/info.txt
Expected Time Ready: Wed Oct 14 11:20:03 EDT 2020

123joshuawu

I'm bad with bash and certificates so ill defer to @jshom but looks good to me

jshom · 2020-10-14T19:45:41Z

Small thing from a glance, seeing file src/web/certificate/READMD.md changed :) did u mean src/web/certificate/README.md. Gonna test with custom cert in a bit, sorry bout the delay on the review here. Looks great!

RichtXO · 2020-10-14T20:02:21Z

Small thing from a glance, seeing file src/web/certificate/READMD.md changed :)

What changed on the README? I was planning to add more stuff on how to obtain a cert and issue it to a CA for free.

did u mean src/web/certificate/README.md. Gonna test with custom cert in a bit, sorry bout the delay on the review here.

It's alright! I didn't know if what I implemented was what you guys had in mind!

Added certs and open both port 80 and 443. Port 80 will redirect to port 443.

jshom · 2020-10-30T20:17:39Z

https://www.ssllabs.com/ssltest/analyze.html?d=li1277%2d238.members.linode.com&s=45.79.178.238&latest

jshom · 2020-10-30T20:19:37Z

WOOOHOOO, thing works. Gonna open new issue to address nginx tweaks for protocols & ciphers to address the test.

src/web/certificate/READMD.md

src/web/nginx.conf

jshom

After removal of the csr check line for provided key/cert, and small whitespace fixes; good for merge!

src/web/scripts/entrypoint.sh

src/web/nginx.conf

ops/provision.js

github-actions · 2020-10-30T20:37:20Z

Deploy Link: https://45.33.88.96/
Branch and Build Info: https://45.33.88.96:3000/info.txt
Expected Time Ready: Fri Oct 30 16:47:11 EDT 2020

github-actions · 2020-10-30T21:18:44Z

Deploy Link: https://97.107.142.48/
Branch and Build Info: https://97.107.142.48:3000/info.txt
Expected Time Ready: Fri Oct 30 17:28:35 EDT 2020

Adding HTTPS on Prod version

20817d2

Added certs and open both port 80 and 443. Port 80 will redirect to port 443.

RichtXO linked an issue Oct 4, 2020 that may be closed by this pull request

Prod - Secure with https #208

Closed

Adding HTTPS on Prod version

5f5e855

Added certs and open both port 80 and 443. Port 80 will redirect to port 443.

jshom force-pushed the HTTPS branch from 20817d2 to 5f5e855 Compare October 6, 2020 21:19

Merge branch 'HTTPS' of https://github.com/YACS-RCOS/yacs.n into HTTPS

d321b54

just testing the https deployment

bba929b

RichtXO added 2 commits October 6, 2020 17:44

Adding HTTPS on Prod version

e45c1e8

Added certs and open both port 80 and 443. Port 80 will redirect to port 443.

just testing the https deployment

4c863c6

jshom mentioned this pull request Oct 6, 2020

allowing multiple ssh keys for feature envs #218

Merged

RichtXO added 3 commits October 6, 2020 19:51

Merge branch 'HTTPS' of https://github.com/YACS-RCOS/yacs.n into HTTPS

3203c79

Merge branch 'master' into HTTPS

663e549

Merge branch 'HTTPS' of https://github.com/YACS-RCOS/yacs.n into HTTPS

38e4153

YACS-RCOS deleted a comment from github-actions bot Oct 9, 2020

RichtXO added 5 commits October 14, 2020 09:57

Changes Josh requested!

0157a1b

small changes of removing spaces

0f7947a

removing the "\" character

cb2c106

idk what im doing... removing strings

12bf378

forgot to add -f

eea4a6c

YACS-RCOS deleted a comment from github-actions bot Oct 14, 2020

RichtXO requested a review from 123joshuawu October 14, 2020 15:12

123joshuawu reviewed Oct 14, 2020

View reviewed changes

RichtXO added 2 commits October 19, 2020 23:36

Adding HTTPS on Prod version

7058bfb

Added certs and open both port 80 and 443. Port 80 will redirect to port 443.

Merge branch 'HTTPS' of https://github.com/YACS-RCOS/yacs.n into HTTPS

c09af9b

jshom reviewed Oct 30, 2020

View reviewed changes

src/web/certificate/READMD.md Outdated Show resolved Hide resolved

jshom reviewed Oct 30, 2020

View reviewed changes

src/web/nginx.conf Show resolved Hide resolved

jshom approved these changes Oct 30, 2020

View reviewed changes

src/web/scripts/entrypoint.sh Outdated Show resolved Hide resolved

src/web/nginx.conf Show resolved Hide resolved

ops/provision.js Show resolved Hide resolved

changes

57b1a8b

jshom mentioned this pull request Oct 30, 2020

Bug — Improve SSL Score #269

Closed

Merge branch 'master' into HTTPS

bb7067e

123joshuawu self-requested a review October 30, 2020 21:23

123joshuawu approved these changes Oct 30, 2020

View reviewed changes

RichtXO merged commit dc82c3d into master Oct 30, 2020

RichtXO deleted the HTTPS branch October 30, 2020 21:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding HTTPS on Prod version #214

Adding HTTPS on Prod version #214

RichtXO commented Oct 4, 2020

github-actions bot commented Oct 4, 2020

123joshuawu commented Oct 4, 2020

RichtXO commented Oct 4, 2020

123joshuawu commented Oct 4, 2020

RichtXO commented Oct 4, 2020

123joshuawu commented Oct 4, 2020

RichtXO commented Oct 4, 2020

123joshuawu commented Oct 5, 2020

github-actions bot commented Oct 6, 2020

github-actions bot commented Oct 6, 2020

jshom commented Oct 6, 2020 •

edited

Loading

github-actions bot commented Oct 6, 2020

jshom commented Oct 6, 2020

RichtXO commented Oct 6, 2020 •

edited

Loading

jshom commented Oct 6, 2020

github-actions bot commented Oct 9, 2020

github-actions bot commented Oct 14, 2020

123joshuawu left a comment

jshom commented Oct 14, 2020

RichtXO commented Oct 14, 2020

jshom commented Oct 30, 2020

jshom commented Oct 30, 2020

jshom left a comment

github-actions bot commented Oct 30, 2020

github-actions bot commented Oct 30, 2020

Adding HTTPS on Prod version #214

Adding HTTPS on Prod version #214

Conversation

RichtXO commented Oct 4, 2020

github-actions bot commented Oct 4, 2020

123joshuawu commented Oct 4, 2020

RichtXO commented Oct 4, 2020

123joshuawu commented Oct 4, 2020

RichtXO commented Oct 4, 2020

123joshuawu commented Oct 4, 2020

RichtXO commented Oct 4, 2020

123joshuawu commented Oct 5, 2020

github-actions bot commented Oct 6, 2020

github-actions bot commented Oct 6, 2020

jshom commented Oct 6, 2020 • edited Loading

github-actions bot commented Oct 6, 2020

jshom commented Oct 6, 2020

RichtXO commented Oct 6, 2020 • edited Loading

jshom commented Oct 6, 2020

github-actions bot commented Oct 9, 2020

github-actions bot commented Oct 14, 2020

123joshuawu left a comment

Choose a reason for hiding this comment

jshom commented Oct 14, 2020

RichtXO commented Oct 14, 2020

jshom commented Oct 30, 2020

jshom commented Oct 30, 2020

jshom left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 30, 2020

github-actions bot commented Oct 30, 2020

jshom commented Oct 6, 2020 •

edited

Loading

RichtXO commented Oct 6, 2020 •

edited

Loading