Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allowing multiple ssh keys for feature envs #218

Merged
merged 2 commits into from
Oct 7, 2020
Merged

allowing multiple ssh keys for feature envs #218

merged 2 commits into from
Oct 7, 2020

Conversation

jshom
Copy link
Contributor

@jshom jshom commented Oct 6, 2020

Issue
Rich needs to be able to access the temp machines for easier testing of #214

Solution
Split the keys of process.env.SSH_PUB_KEYS by newline and filter out empty newlines to provide list of keys.

Format of secret is:

key1
key2
etc..

@jshom jshom added the DevEx Improvement to developer experience or code quality++ label Oct 6, 2020
@jshom jshom requested review from 123joshuawu and RichtXO October 6, 2020 23:09
@jshom
Copy link
Contributor Author

jshom commented Oct 6, 2020

(sorry about conflating the lint fixes)

@github-actions
Copy link

github-actions bot commented Oct 6, 2020

Deploy Link: /
Branch and Build Info: :3000/info.txt
Expected Time Ready: Tue Oct 6 19:20:33 EDT 2020

@github-actions
Copy link

github-actions bot commented Oct 6, 2020

Deploy Link: http://45.33.71.174/
Branch and Build Info: http://45.33.71.174:3000/info.txt
Expected Time Ready: Tue Oct 6 19:26:54 EDT 2020

@jshom
Copy link
Contributor Author

jshom commented Oct 6, 2020 •
edited
Loading

@RichtXO can you trying getting in ssh root@45.33.71.174, lmk if it works

@RichtXO
Copy link
Member

RichtXO commented Oct 6, 2020

Yes sir! Asked for password for my private key! @jshom

@jshom jshom merged commit 2ea2c38 into master Oct 7, 2020
@jshom jshom deleted the multi-ssh-keys-for-temp-deploys branch October 7, 2020 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichtXO RichtXO RichtXO approved these changes

@123joshuawu 123joshuawu Awaiting requested review from 123joshuawu

Assignees
No one assigned
Labels
DevEx Improvement to developer experience or code quality++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jshom @RichtXO