Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SubsemesterScheduler, component reorganization, Prettier code style, add jsdocs #51

Merged
merged 24 commits into from
Mar 16, 2020

Conversation

123joshuawu
Copy link
Member

@123joshuawu 123joshuawu commented Mar 13, 2020

TODO:

  • review ICS calendar changes, idk if it works @CoreyBuckley
  • more thoroughly test subsemester functionality
  • documentation generation for sfc using jsdoc annotations

Two main aspects of the changes below are

  1. Added SubSemesterScheduler for toggling schedules based on subsemester
  2. Splitting CourseList and SelectedCourses into separate components

Additional noteworthy changes:

  • Added proxy to Vue devServer so CORS no longer required in backend
  • Added prettier for enforcing code style
  • Added jsconfig.json for vscode intellisense import of '@/' webpack alias
  • Added jsdoc.config.json for jsdoc documentation generation

Overview of SubSemesterScheduler
SubSemeseterScheduler holds a list of Schedules each associated with a SubSemester. When adding courseSections the SubSemesterScheduler determines which SubSemester the course affects using withinCourseDuration and then adds the courseSection to the affected Schedule. For removal, atm every Schedule attempts to remove the courseSection. Since the number of comparisons are relatively low and each operation is cheap, the approach should work fine. Additionally, SubSemesterScheduler also adds the affected subsemester to the ScheduleConflict error.

Part of this PR was to ensure the Schedule had no concept of subsemesters, keep it such that a Schedule only operates with courseSections. My thinking is for Schedule to only be concerned with ScheduleConflict between courseSections. Other concepts like courses or subsemesters or semesters should be handled outside of Schedule.

Overview of Front-end Components:
The basic design is Main contains various components that each have their own function. Any state that involves more than one child component is hoisted to Main and children components make changes through events. This can be seen in selectedCourses which is affected by/affects CourseList, SelectedCourses, Schedules. The management of Schedules could be moved to a separate module along with the scheduler, but for now that functionality resides in Main.

Additionally, an attempt was made to move common functionality into reusable modules. ColorService was made into a singleton. Mixins were created for TimeDateMixin and Notifications, however after further research, it is probably better to move away from mixins.
Honestly im rambling im tired lol

@123joshuawu 123joshuawu linked an issue Mar 13, 2020 that may be closed by this pull request
…ed absolute urls in services to relative paths.
Copy link
Contributor

@CoreyBuckley CoreyBuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort by start date
image

src/yacs-web/src/components/SelectedCourses.vue Outdated Show resolved Hide resolved
src/yacs-web/src/components/SelectedCourses.vue Outdated Show resolved Hide resolved
src/yacs-web/src/pages/Main.vue Outdated Show resolved Hide resolved
src/yacs-web/src/services/ScheduleService.js Outdated Show resolved Hide resolved
@CoreyBuckley
Copy link
Contributor

CoreyBuckley commented Mar 14, 2020

Honestly, very impressive. Nice job.

Yes, export to ICS still works.

I have one maybe controversial thought:

If I have one 12-week course and one 6-week course, then there's bound to be overlap. However, if I look at that 12-week subsemester, I will not see the 6-week course.

E.g.

12-week view

image

6-week view

image

COMM-2520 doesn't show up in the 12-week view. Should it? IMO, feel like it makes logical sense for it to appear, but I can see why you don't show it.

I'm starting to feel like a date range / configurable timeline makes most sense from a user perspective. Similar to one of these:

Date range

image

Configurable timeline (forgive my quick CSS art, couldn't find a good pic)

image

(Would have built in 'ticks' on the slider for each possible course start / end date)

Future feature? 😅

…nging the data source / (schedule service for a subsemester)
@123joshuawu
Copy link
Member Author

Yeah I like the idea of being able to see stuff on one schedule.
One of the designs during the brainstorms that I really liked was something like this
Screen Shot 2020-03-14 at 2 59 18 PM
Hopefully just by looking at it it should be pretty clear which subsemester each course belongs to.
The left and right halves are two variations on the spacing/border placements. But the main idea was to show all the courses in one schedule and have half blocks for each subsemester.
But we eventually went with the toggle.

@CoreyBuckley
Copy link
Contributor

CoreyBuckley commented Mar 14, 2020

I like the idea, I just think there's still a possibility to misinterpret it. A user misinterpreting the distinction of subsemester possibly means they attend a non-going class. 😅

I think if you included the start date on the schedule event for those courses in that later 6-week half it'd be much more obvious.

Example: (pay no attention to the real course start dates)

image

Other than that, I think I prefer it TBH.

@123joshuawu
Copy link
Member Author

Yeah the only thing is if the day came and RPI decided to do three subsemesters instead of two, then we'd have to redesign again lol.

@123joshuawu 123joshuawu added documentation Improvements or additions to documentation and removed in progress labels Mar 15, 2020
@123joshuawu 123joshuawu changed the title WIP: Add subsemester and reorganization Add SubsemesterScheduler, component reorganization, Prettier code style, add jsdocs Mar 15, 2020
@jshom
Copy link
Contributor

jshom commented Mar 15, 2020

This, is, so, cool!
Just one thing, seems when I click a course the event is not filling in with any info. Can you add class.title and class.section. thx!
Screen Shot 2020-03-15 at 1 48 38 AM

@jshom
Copy link
Contributor

jshom commented Mar 15, 2020

Also, the whole semester (05/25-08/20) should not be an option in the dropdown. There are in practice two parts of the semester. We can defer this to a solution where in the admin panel we select which date ranges map to which "semester parts" then we can show semester part.

So example:
date range (05/25-08/20) belongs to part1 and part 2
date range (07/12-08/20) belong only to part 2

Then we would show in dropdown part 1, part 2 instead of unnamed date ranges

What you think? No need to build now, after cal event change we should be good for merge.

@123joshuawu
Copy link
Member Author

@jshom Yeah I like the use of 'semester parts' over date ranges, that's a really good idea.

As for the event not showing info, I had the issue a little back but it should be fixed by now, make sure you have all the recent commits.
Displaying the course information is going to be a little problematic right now just because the Schedule and its child ScheduleEvent only have access to the CourseSession. I'm planning on moving Course, CourseSection, and CourseSession to centralized store some time soon which will fix this issue, but for now, it just shows crn and section number.

@jshom jshom merged commit 487ae88 into master Mar 16, 2020
@123joshuawu 123joshuawu deleted the add_subsemester branch March 20, 2020 16:45
griteetan pushed a commit that referenced this pull request Apr 1, 2020
…le, add jsdocs (#51)

* Move common functionality to separate modules. Started as mixins but now trying to move away from mixins

* Moved data parsing and 'enrichment' to YacsService

* Added new service for managing multiple schedules, one for each subsemester

* Moved courseIdentifier to YacsService. Added option to provide conflictCheck results to addcourseSection to avoid repeat code execution

* Reorganized modules. Moved CourseList out of Main and SelectedCourses out of Schedule. selectedCourses state hoisted to Main and children components effect changes through events

* Cosmetic changes and inclusion of index.js files to allow module imports from directory

* Changed to singleton

* Added proxy to devServer so CORS no longer required on backend. Changed absolute urls in services to relative paths.

* Use only one schedule component for each subsemester, dynamically changing the data source / (schedule service for a subsemester)

* Revert to v-show and add v-if wrapper

* Allow adding multiple sections from a course

* Refactor semester.text to semester.display_string

* Moved .schedule-event css from Schedule to ScheduleEvent

* Remove all ics calendar implementation

* Use scheduler.scheduleSubsemesters as subsemester options

* Remove index.js for components to fix some weird import errors

* Add sorting to YacsService

* Add prettier code formatter to start to enforce code style

* Move section.selected from Schedule.addCourseSection to Main.vue

* Update config files to enable @ webpack import alias for src/ directory

* Use Prettier as code style. Added type definitions in index.d.ts. Added documentation for most functionality.

* Move type definitions back to jsdoc and store in typedef.js

* Add directory for controllers. Move ScheduleService and SubsemesterScheduler to controllers. Refactor ColorService to export functions.

* Add config file for generating documentation for .js files using jsdoc

Co-authored-by: corey buckley <coreybuckley13@gmail.com>
marchdan pushed a commit that referenced this pull request Mar 9, 2021
RichtXO added a commit that referenced this pull request Mar 23, 2021
* First go at issue 373. Moved the Sign Up button into the Log In pop up window

* Updated summer2021 to account for partial semesters and update summer2021.csv (#413)

* Linked Course Names (#407)

* Proposed solution to Issue 387. The course names are now links to course pages.

* Created function for finding explore link

* Template strings because pretty

* beep boop Github Action Master Branch CI Prettier hard at work

* Added removed subsmester filter funcionality from #51 (#417)

* beep boop Github Action Master Branch CI Prettier hard at work

* Updating summer 2021 CSV (#416)

* Updating summer 2021 CSV

Just updating it periodically

* adding fall 2021

* updated courses

* updating summer :)

* Fixed the spacing between the buttons. Should be good now :)

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updated CSVs (#426)

* updated

* updated semesters and maybe a fix to the test

* just testing

* updated

* updated csvs

* updated

* Moving to vuex (#425)

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* beep boop Github Action Master Branch CI Prettier hard at work

* First go at issue 373. Moved the Sign Up button into the Log In pop up window

* Fixed the spacing between the buttons. Should be good now :)

Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com>
Co-authored-by: I'm a Github Action <beepboop@github.com>
Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joshua Wu <joshuawu3@gmail.com>
RichtXO added a commit that referenced this pull request Apr 8, 2021
* Update ColorService.js

* Update ColorService.js

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updated CSVs (#426)

* updated

* updated semesters and maybe a fix to the test

* just testing

* updated

* updated csvs

* updated

* Moving to vuex (#425)

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* beep boop Github Action Master Branch CI Prettier hard at work

* Dark mode visibility (#423)

* Update CourseListing.vue

Update importance of color scheme

* Update dark.scss

Update button colors

* Update dark.scss

corrected line that was used for debugging

* Update dark.scss

Added component for hovering over course boxes

* Update SubjectExplorer.vue

Fixed hovering color switch (prev when you hovered over course box color did not switch)

* Update SubjectExplorer.vue

Slight color modification (to match other hover colors)

* Update dark.scss

comment cleanup

* Updating summer 2021 CSV (#416)

* Updating summer 2021 CSV

Just updating it periodically

* adding fall 2021

* updated courses

* updating summer :)

* Update CourseListing.vue

bug fix for clicking prerequisites course (prev forced back to light mode)

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updated CSVs (#426)

* updated

* updated semesters and maybe a fix to the test

* just testing

* updated

* updated csvs

* updated

* Update CourseListing.vue

Update importance of color scheme

* Update dark.scss

Update button colors

* Update dark.scss

corrected line that was used for debugging

* Update dark.scss

Added component for hovering over course boxes

* Update SubjectExplorer.vue

Fixed hovering color switch (prev when you hovered over course box color did not switch)

* Update SubjectExplorer.vue

Slight color modification (to match other hover colors)

* Update dark.scss

comment cleanup

* Update CourseListing.vue

bug fix for clicking prerequisites course (prev forced back to light mode)

Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Move Sign Up Button (#411)

* First go at issue 373. Moved the Sign Up button into the Log In pop up window

* Updated summer2021 to account for partial semesters and update summer2021.csv (#413)

* Linked Course Names (#407)

* Proposed solution to Issue 387. The course names are now links to course pages.

* Created function for finding explore link

* Template strings because pretty

* beep boop Github Action Master Branch CI Prettier hard at work

* Added removed subsmester filter funcionality from #51 (#417)

* beep boop Github Action Master Branch CI Prettier hard at work

* Updating summer 2021 CSV (#416)

* Updating summer 2021 CSV

Just updating it periodically

* adding fall 2021

* updated courses

* updating summer :)

* Fixed the spacing between the buttons. Should be good now :)

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updated CSVs (#426)

* updated

* updated semesters and maybe a fix to the test

* just testing

* updated

* updated csvs

* updated

* Moving to vuex (#425)

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* beep boop Github Action Master Branch CI Prettier hard at work

* First go at issue 373. Moved the Sign Up button into the Log In pop up window

* Fixed the spacing between the buttons. Should be good now :)

Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com>
Co-authored-by: I'm a Github Action <beepboop@github.com>
Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joshua Wu <joshuawu3@gmail.com>

* beep boop Github Action Master Branch CI Prettier hard at work

* Bump lxml from 4.6.2 to 4.6.3 in /tests (#430)

Bumps [lxml](https://github.com/lxml/lxml) from 4.6.2 to 4.6.3.
- [Release notes](https://github.com/lxml/lxml/releases)
- [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt)
- [Commits](lxml/lxml@lxml-4.6.2...lxml-4.6.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump pyyaml from 5.3.1 to 5.4 in /tests (#434)

Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.3.1 to 5.4.
- [Release notes](https://github.com/yaml/pyyaml/releases)
- [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES)
- [Commits](yaml/pyyaml@5.3.1...5.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update ColorService.js

* Update ColorService.js

* Update ColorService.js

* Update ColorService.js

Co-authored-by: JaBeast13 <JaBeast13@users.noreply.github.com>
Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joshua Wu <joshuawu3@gmail.com>
Co-authored-by: I'm a Github Action <beepboop@github.com>
Co-authored-by: keerti-sundaram <70778626+keerti-sundaram@users.noreply.github.com>
Co-authored-by: Nicole Marie Gizzo <gizzon@rpi.edu>
Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com>
RichtXO added a commit that referenced this pull request Apr 15, 2021
* adding 404 page :)

* Updated CSVs (#426)

* updated

* updated semesters and maybe a fix to the test

* just testing

* updated

* updated csvs

* updated

* Moving to vuex (#425)

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* beep boop Github Action Master Branch CI Prettier hard at work

* Dark mode visibility (#423)

* Update CourseListing.vue

Update importance of color scheme

* Update dark.scss

Update button colors

* Update dark.scss

corrected line that was used for debugging

* Update dark.scss

Added component for hovering over course boxes

* Update SubjectExplorer.vue

Fixed hovering color switch (prev when you hovered over course box color did not switch)

* Update SubjectExplorer.vue

Slight color modification (to match other hover colors)

* Update dark.scss

comment cleanup

* Updating summer 2021 CSV (#416)

* Updating summer 2021 CSV

Just updating it periodically

* adding fall 2021

* updated courses

* updating summer :)

* Update CourseListing.vue

bug fix for clicking prerequisites course (prev forced back to light mode)

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updated CSVs (#426)

* updated

* updated semesters and maybe a fix to the test

* just testing

* updated

* updated csvs

* updated

* Update CourseListing.vue

Update importance of color scheme

* Update dark.scss

Update button colors

* Update dark.scss

corrected line that was used for debugging

* Update dark.scss

Added component for hovering over course boxes

* Update SubjectExplorer.vue

Fixed hovering color switch (prev when you hovered over course box color did not switch)

* Update SubjectExplorer.vue

Slight color modification (to match other hover colors)

* Update dark.scss

comment cleanup

* Update CourseListing.vue

bug fix for clicking prerequisites course (prev forced back to light mode)

Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Move Sign Up Button (#411)

* First go at issue 373. Moved the Sign Up button into the Log In pop up window

* Updated summer2021 to account for partial semesters and update summer2021.csv (#413)

* Linked Course Names (#407)

* Proposed solution to Issue 387. The course names are now links to course pages.

* Created function for finding explore link

* Template strings because pretty

* beep boop Github Action Master Branch CI Prettier hard at work

* Added removed subsmester filter funcionality from #51 (#417)

* beep boop Github Action Master Branch CI Prettier hard at work

* Updating summer 2021 CSV (#416)

* Updating summer 2021 CSV

Just updating it periodically

* adding fall 2021

* updated courses

* updating summer :)

* Fixed the spacing between the buttons. Should be good now :)

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updated CSVs (#426)

* updated

* updated semesters and maybe a fix to the test

* just testing

* updated

* updated csvs

* updated

* Moving to vuex (#425)

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* beep boop Github Action Master Branch CI Prettier hard at work

* First go at issue 373. Moved the Sign Up button into the Log In pop up window

* Fixed the spacing between the buttons. Should be good now :)

Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com>
Co-authored-by: I'm a Github Action <beepboop@github.com>
Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joshua Wu <joshuawu3@gmail.com>

* beep boop Github Action Master Branch CI Prettier hard at work

* adding 404 page :)

* Fixed some things

* Bump lxml from 4.6.2 to 4.6.3 in /tests (#430)

Bumps [lxml](https://github.com/lxml/lxml) from 4.6.2 to 4.6.3.
- [Release notes](https://github.com/lxml/lxml/releases)
- [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt)
- [Commits](lxml/lxml@lxml-4.6.2...lxml-4.6.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* adding an easter egg :]

* edit egg to fix all devices

not pretty, prob would anger everyone, but it works :)))

* Bump pyyaml from 5.3.1 to 5.4 in /tests (#434)

Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.3.1 to 5.4.
- [Release notes](https://github.com/yaml/pyyaml/releases)
- [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES)
- [Commits](yaml/pyyaml@5.3.1...5.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix added course to removeCourseSection event (#435)

* updated

* Auto update prod fall 2021 courses every hour (#436)

* Add workflow to update prod courses

* test run on current branch

* Add python setup

* run on ubuntu latest

* Set working-direction for upload

* Update every hour. Reduce class cache to an hour

* Make semester publicly visible

* Rename to Semester Data Update

* Bump y18n from 4.0.0 to 4.0.1 in /tests/integration (#438)

Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* typo fix for id (#439)

* title fixed and keywords smol refactor (#441)

* beep boop Github Action Master Branch CI Prettier hard at work

* Update ColorService.js (#421)

* Update ColorService.js

* Update ColorService.js

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updated CSVs (#426)

* updated

* updated semesters and maybe a fix to the test

* just testing

* updated

* updated csvs

* updated

* Moving to vuex (#425)

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* beep boop Github Action Master Branch CI Prettier hard at work

* Dark mode visibility (#423)

* Update CourseListing.vue

Update importance of color scheme

* Update dark.scss

Update button colors

* Update dark.scss

corrected line that was used for debugging

* Update dark.scss

Added component for hovering over course boxes

* Update SubjectExplorer.vue

Fixed hovering color switch (prev when you hovered over course box color did not switch)

* Update SubjectExplorer.vue

Slight color modification (to match other hover colors)

* Update dark.scss

comment cleanup

* Updating summer 2021 CSV (#416)

* Updating summer 2021 CSV

Just updating it periodically

* adding fall 2021

* updated courses

* updating summer :)

* Update CourseListing.vue

bug fix for clicking prerequisites course (prev forced back to light mode)

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updated CSVs (#426)

* updated

* updated semesters and maybe a fix to the test

* just testing

* updated

* updated csvs

* updated

* Update CourseListing.vue

Update importance of color scheme

* Update dark.scss

Update button colors

* Update dark.scss

corrected line that was used for debugging

* Update dark.scss

Added component for hovering over course boxes

* Update SubjectExplorer.vue

Fixed hovering color switch (prev when you hovered over course box color did not switch)

* Update SubjectExplorer.vue

Slight color modification (to match other hover colors)

* Update dark.scss

comment cleanup

* Update CourseListing.vue

bug fix for clicking prerequisites course (prev forced back to light mode)

Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Move Sign Up Button (#411)

* First go at issue 373. Moved the Sign Up button into the Log In pop up window

* Updated summer2021 to account for partial semesters and update summer2021.csv (#413)

* Linked Course Names (#407)

* Proposed solution to Issue 387. The course names are now links to course pages.

* Created function for finding explore link

* Template strings because pretty

* beep boop Github Action Master Branch CI Prettier hard at work

* Added removed subsmester filter funcionality from #51 (#417)

* beep boop Github Action Master Branch CI Prettier hard at work

* Updating summer 2021 CSV (#416)

* Updating summer 2021 CSV

Just updating it periodically

* adding fall 2021

* updated courses

* updating summer :)

* Fixed the spacing between the buttons. Should be good now :)

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updated CSVs (#426)

* updated

* updated semesters and maybe a fix to the test

* just testing

* updated

* updated csvs

* updated

* Moving to vuex (#425)

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* beep boop Github Action Master Branch CI Prettier hard at work

* First go at issue 373. Moved the Sign Up button into the Log In pop up window

* Fixed the spacing between the buttons. Should be good now :)

Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com>
Co-authored-by: I'm a Github Action <beepboop@github.com>
Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joshua Wu <joshuawu3@gmail.com>

* beep boop Github Action Master Branch CI Prettier hard at work

* Bump lxml from 4.6.2 to 4.6.3 in /tests (#430)

Bumps [lxml](https://github.com/lxml/lxml) from 4.6.2 to 4.6.3.
- [Release notes](https://github.com/lxml/lxml/releases)
- [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt)
- [Commits](lxml/lxml@lxml-4.6.2...lxml-4.6.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump pyyaml from 5.3.1 to 5.4 in /tests (#434)

Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.3.1 to 5.4.
- [Release notes](https://github.com/yaml/pyyaml/releases)
- [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES)
- [Commits](yaml/pyyaml@5.3.1...5.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update ColorService.js

* Update ColorService.js

* Update ColorService.js

* Update ColorService.js

Co-authored-by: JaBeast13 <JaBeast13@users.noreply.github.com>
Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joshua Wu <joshuawu3@gmail.com>
Co-authored-by: I'm a Github Action <beepboop@github.com>
Co-authored-by: keerti-sundaram <70778626+keerti-sundaram@users.noreply.github.com>
Co-authored-by: Nicole Marie Gizzo <gizzon@rpi.edu>
Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com>

* Color blind assist (#440)

* Added color blind friendly colors

* Added color blind assistance toggle

* Color blind assistance cookie

* Changed course link color to black

* beep boop Github Action Master Branch CI Prettier hard at work

* adding the overflow tag

* adding 404 page :)

* Fixed some things

* adding an easter egg :]

* edit egg to fix all devices

not pretty, prob would anger everyone, but it works :)))

* adding the overflow tag

* small change

Co-authored-by: Joshua Wu <joshuawu3@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: I'm a Github Action <beepboop@github.com>
Co-authored-by: keerti-sundaram <70778626+keerti-sundaram@users.noreply.github.com>
Co-authored-by: Nicole Marie Gizzo <gizzon@rpi.edu>
Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com>
Co-authored-by: Jacob Shomstein <jacob@shomstein.com>
Co-authored-by: JaBeast13 <78986694+JaBeast13@users.noreply.github.com>
Co-authored-by: JaBeast13 <JaBeast13@users.noreply.github.com>
Co-authored-by: NickKing24 <78986301+NickKing24@users.noreply.github.com>
RichtXO added a commit that referenced this pull request May 1, 2021
* Adding Lighthouse audit

Was just thinking of automating this process

* made changes

what's docker again?

* run plz?

* cert errors have returned to bite my ass...

* combining the temp_deploy with the CI

* dam it

* add seed data

* will it work now?

* just want to see it work :/

* more changes for the data

* changes

* changes

* what is it outputtng...

* sleep?

* remove space

* finally done!

* run this in desktop?

* now it should work

* adding screenEmulation

* test...

* test

* adding back the desktop

* Now Adding 404 Page! (#429)

* adding 404 page :)

* Updated CSVs (#426)

* updated

* updated semesters and maybe a fix to the test

* just testing

* updated

* updated csvs

* updated

* Moving to vuex (#425)

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* beep boop Github Action Master Branch CI Prettier hard at work

* Dark mode visibility (#423)

* Update CourseListing.vue

Update importance of color scheme

* Update dark.scss

Update button colors

* Update dark.scss

corrected line that was used for debugging

* Update dark.scss

Added component for hovering over course boxes

* Update SubjectExplorer.vue

Fixed hovering color switch (prev when you hovered over course box color did not switch)

* Update SubjectExplorer.vue

Slight color modification (to match other hover colors)

* Update dark.scss

comment cleanup

* Updating summer 2021 CSV (#416)

* Updating summer 2021 CSV

Just updating it periodically

* adding fall 2021

* updated courses

* updating summer :)

* Update CourseListing.vue

bug fix for clicking prerequisites course (prev forced back to light mode)

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updated CSVs (#426)

* updated

* updated semesters and maybe a fix to the test

* just testing

* updated

* updated csvs

* updated

* Update CourseListing.vue

Update importance of color scheme

* Update dark.scss

Update button colors

* Update dark.scss

corrected line that was used for debugging

* Update dark.scss

Added component for hovering over course boxes

* Update SubjectExplorer.vue

Fixed hovering color switch (prev when you hovered over course box color did not switch)

* Update SubjectExplorer.vue

Slight color modification (to match other hover colors)

* Update dark.scss

comment cleanup

* Update CourseListing.vue

bug fix for clicking prerequisites course (prev forced back to light mode)

Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Move Sign Up Button (#411)

* First go at issue 373. Moved the Sign Up button into the Log In pop up window

* Updated summer2021 to account for partial semesters and update summer2021.csv (#413)

* Linked Course Names (#407)

* Proposed solution to Issue 387. The course names are now links to course pages.

* Created function for finding explore link

* Template strings because pretty

* beep boop Github Action Master Branch CI Prettier hard at work

* Added removed subsmester filter funcionality from #51 (#417)

* beep boop Github Action Master Branch CI Prettier hard at work

* Updating summer 2021 CSV (#416)

* Updating summer 2021 CSV

Just updating it periodically

* adding fall 2021

* updated courses

* updating summer :)

* Fixed the spacing between the buttons. Should be good now :)

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updated CSVs (#426)

* updated

* updated semesters and maybe a fix to the test

* just testing

* updated

* updated csvs

* updated

* Moving to vuex (#425)

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* beep boop Github Action Master Branch CI Prettier hard at work

* First go at issue 373. Moved the Sign Up button into the Log In pop up window

* Fixed the spacing between the buttons. Should be good now :)

Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com>
Co-authored-by: I'm a Github Action <beepboop@github.com>
Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joshua Wu <joshuawu3@gmail.com>

* beep boop Github Action Master Branch CI Prettier hard at work

* adding 404 page :)

* Fixed some things

* Bump lxml from 4.6.2 to 4.6.3 in /tests (#430)

Bumps [lxml](https://github.com/lxml/lxml) from 4.6.2 to 4.6.3.
- [Release notes](https://github.com/lxml/lxml/releases)
- [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt)
- [Commits](lxml/lxml@lxml-4.6.2...lxml-4.6.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* adding an easter egg :]

* edit egg to fix all devices

not pretty, prob would anger everyone, but it works :)))

* Bump pyyaml from 5.3.1 to 5.4 in /tests (#434)

Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.3.1 to 5.4.
- [Release notes](https://github.com/yaml/pyyaml/releases)
- [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES)
- [Commits](yaml/pyyaml@5.3.1...5.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix added course to removeCourseSection event (#435)

* updated

* Auto update prod fall 2021 courses every hour (#436)

* Add workflow to update prod courses

* test run on current branch

* Add python setup

* run on ubuntu latest

* Set working-direction for upload

* Update every hour. Reduce class cache to an hour

* Make semester publicly visible

* Rename to Semester Data Update

* Bump y18n from 4.0.0 to 4.0.1 in /tests/integration (#438)

Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* typo fix for id (#439)

* title fixed and keywords smol refactor (#441)

* beep boop Github Action Master Branch CI Prettier hard at work

* Update ColorService.js (#421)

* Update ColorService.js

* Update ColorService.js

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updated CSVs (#426)

* updated

* updated semesters and maybe a fix to the test

* just testing

* updated

* updated csvs

* updated

* Moving to vuex (#425)

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* beep boop Github Action Master Branch CI Prettier hard at work

* Dark mode visibility (#423)

* Update CourseListing.vue

Update importance of color scheme

* Update dark.scss

Update button colors

* Update dark.scss

corrected line that was used for debugging

* Update dark.scss

Added component for hovering over course boxes

* Update SubjectExplorer.vue

Fixed hovering color switch (prev when you hovered over course box color did not switch)

* Update SubjectExplorer.vue

Slight color modification (to match other hover colors)

* Update dark.scss

comment cleanup

* Updating summer 2021 CSV (#416)

* Updating summer 2021 CSV

Just updating it periodically

* adding fall 2021

* updated courses

* updating summer :)

* Update CourseListing.vue

bug fix for clicking prerequisites course (prev forced back to light mode)

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updated CSVs (#426)

* updated

* updated semesters and maybe a fix to the test

* just testing

* updated

* updated csvs

* updated

* Update CourseListing.vue

Update importance of color scheme

* Update dark.scss

Update button colors

* Update dark.scss

corrected line that was used for debugging

* Update dark.scss

Added component for hovering over course boxes

* Update SubjectExplorer.vue

Fixed hovering color switch (prev when you hovered over course box color did not switch)

* Update SubjectExplorer.vue

Slight color modification (to match other hover colors)

* Update dark.scss

comment cleanup

* Update CourseListing.vue

bug fix for clicking prerequisites course (prev forced back to light mode)

Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Move Sign Up Button (#411)

* First go at issue 373. Moved the Sign Up button into the Log In pop up window

* Updated summer2021 to account for partial semesters and update summer2021.csv (#413)

* Linked Course Names (#407)

* Proposed solution to Issue 387. The course names are now links to course pages.

* Created function for finding explore link

* Template strings because pretty

* beep boop Github Action Master Branch CI Prettier hard at work

* Added removed subsmester filter funcionality from #51 (#417)

* beep boop Github Action Master Branch CI Prettier hard at work

* Updating summer 2021 CSV (#416)

* Updating summer 2021 CSV

Just updating it periodically

* adding fall 2021

* updated courses

* updating summer :)

* Fixed the spacing between the buttons. Should be good now :)

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updated CSVs (#426)

* updated

* updated semesters and maybe a fix to the test

* just testing

* updated

* updated csvs

* updated

* Moving to vuex (#425)

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

* fixed the CI problem (#427)

* Signed-off-by: dependabot[bot] <support@github.com> (#428)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Move selectedSemester, courses, semesters, departments, subsemesters into vuex

* Add isLoadingCourses vuex state

* Add check for courseObj in course page

* Default empty schedule for schedule controller

* Add route guard to student routes to load semester

* Load student courses on courses change

* Only add meta for coursepage if courseObj exists

Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* beep boop Github Action Master Branch CI Prettier hard at work

* First go at issue 373. Moved the Sign Up button into the Log In pop up window

* Fixed the spacing between the buttons. Should be good now :)

Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com>
Co-authored-by: I'm a Github Action <beepboop@github.com>
Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joshua Wu <joshuawu3@gmail.com>

* beep boop Github Action Master Branch CI Prettier hard at work

* Bump lxml from 4.6.2 to 4.6.3 in /tests (#430)

Bumps [lxml](https://github.com/lxml/lxml) from 4.6.2 to 4.6.3.
- [Release notes](https://github.com/lxml/lxml/releases)
- [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt)
- [Commits](lxml/lxml@lxml-4.6.2...lxml-4.6.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump pyyaml from 5.3.1 to 5.4 in /tests (#434)

Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.3.1 to 5.4.
- [Release notes](https://github.com/yaml/pyyaml/releases)
- [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES)
- [Commits](yaml/pyyaml@5.3.1...5.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update ColorService.js

* Update ColorService.js

* Update ColorService.js

* Update ColorService.js

Co-authored-by: JaBeast13 <JaBeast13@users.noreply.github.com>
Co-authored-by: Richard Tsai <RichtXO@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joshua Wu <joshuawu3@gmail.com>
Co-authored-by: I'm a Github Action <beepboop@github.com>
Co-authored-by: keerti-sundaram <70778626+keerti-sundaram@users.noreply.github.com>
Co-authored-by: Nicole Marie Gizzo <gizzon@rpi.edu>
Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com>

* Color blind assist (#440)

* Added color blind friendly colors

* Added color blind assistance toggle

* Color blind assistance cookie

* Changed course link color to black

* beep boop Github Action Master Branch CI Prettier hard at work

* adding the overflow tag

* adding 404 page :)

* Fixed some things

* adding an easter egg :]

* edit egg to fix all devices

not pretty, prob would anger everyone, but it works :)))

* adding the overflow tag

* small change

Co-authored-by: Joshua Wu <joshuawu3@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: I'm a Github Action <beepboop@github.com>
Co-authored-by: keerti-sundaram <70778626+keerti-sundaram@users.noreply.github.com>
Co-authored-by: Nicole Marie Gizzo <gizzon@rpi.edu>
Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com>
Co-authored-by: Jacob Shomstein <jacob@shomstein.com>
Co-authored-by: JaBeast13 <78986694+JaBeast13@users.noreply.github.com>
Co-authored-by: JaBeast13 <JaBeast13@users.noreply.github.com>
Co-authored-by: NickKing24 <78986301+NickKing24@users.noreply.github.com>

* beep boop Github Action Master Branch CI Prettier hard at work

* Automatically Switch to Dark Mode (#410)

* Feat.: Add dark mode following device color scheme

* Fix: Reduce flickers caused by loading courses

* Feat.: Add method of change scheme to device color

* FIX: Change the implementation of dark mode switch

* Fix: Change positions of toaster notifications

* Feat.: Change color scheme without refreshing

* Fix: Coding style enhancements

* Fix: Code readability

* Feat.: Add dark mode following device color scheme

* Fix: Reduce flickers caused by loading courses

* Feat.: Add method of change scheme to device color

* FIX: Change the implementation of dark mode switch

* Fix: Change positions of toaster notifications

* Feat.: Change color scheme without refreshing

* Fix: Coding style enhancements

* Fix: Code readability

* Fix: Resolved conflicts

* fix: code duplicates and fix cookie reset function

Co-authored-by: Gitea <gitea@fake.local>

* beep boop Github Action Master Branch CI Prettier hard at work

* Nginx cache Solution (#424)

* nginx cache solution

idk if this would work, but its a test!

* changed apt to apt-get

* hopefully this works :)

* Re-enable caching for JS and CSS files and Brotli

* caching json to 5mins

* a

* updating

* block certain user agent

* nginx cache solution

idk if this would work, but its a test!

* changed apt to apt-get

* hopefully this works :)

* Re-enable caching for JS and CSS files and Brotli

* caching json to 5mins

* a

* updating

* block certain user agent

* removing brotli, gzip might be better

* changed micro_cache to last 1 hour

* changing some things

* made changes (and idk what prompt the force push)

* nginx cache solution

idk if this would work, but its a test!

* changed apt to apt-get

* hopefully this works :)

* Re-enable caching for JS and CSS files and Brotli

* caching json to 5mins

* a

* updating

* block certain user agent

* nginx cache solution

idk if this would work, but its a test!

* changed apt to apt-get

* hopefully this works :)

* Re-enable caching for JS and CSS files and Brotli

* caching json to 5mins

* a

* updating

* block certain user agent

* removing brotli, gzip might be better

* changed micro_cache to last 1 hour

* changing some things

* made changes (and idk what prompt the force push)

* adding notFoundPage

* just updating csv files

* PWA Coming to YACS (#432)

* adding default pwa-generated files

Got to have a YACS image file with all different dimensions.

* Too much assets... May need to edit manifest.json

* beep boop Github Action Master Branch CI Prettier hard at work

* changing background color

* linking apple image

* Adding Lighthouse audit

Was just thinking of automating this process

* made changes

what's docker again?

* run plz?

* cert errors have returned to bite my ass...

* combining the temp_deploy with the CI

* dam it

* add seed data

* will it work now?

* just want to see it work :/

* more changes for the data

* changes

* changes

* what is it outputtng...

* sleep?

* remove space

* finally done!

* run this in desktop?

* now it should work

* adding screenEmulation

* test...

* test

* adding back the desktop

* final changes

* small syntax difference?

* removed useless docker-compose build

* seperated the PR CD and CI

* name changed

* trying out terosh/lighthouse-ci-action

* removing spaces

* changing back

Had to move the lighthouserc.js to the workflow folder for it to work, and dont want to do that.
Also, using the treosh action just takes some thing out of the js file anyway, and having all lighthouse config stuff in 1 file is better to manage

* adding url

* adding url

* Revert "name changed"

This reverts commit 30a9086.

* asdf

* Revert "asdf"

This reverts commit e08c0f4.

* Revert "Revert "name changed""

This reverts commit 0a33b1b.

* Revert "adding url"

This reverts commit 95b85ab.

* Revert "adding url"

This reverts commit b7d044f.

* Revert "changing back"

This reverts commit 0998119.

* Revert "removing spaces"

This reverts commit e67bb7e.

* Revert "trying out terosh/lighthouse-ci-action"

This reverts commit dbbdbf3.

Co-authored-by: Joshua Wu <joshuawu3@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: I'm a Github Action <beepboop@github.com>
Co-authored-by: keerti-sundaram <70778626+keerti-sundaram@users.noreply.github.com>
Co-authored-by: Nicole Marie Gizzo <gizzon@rpi.edu>
Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com>
Co-authored-by: Jacob Shomstein <jacob@shomstein.com>
Co-authored-by: JaBeast13 <78986694+JaBeast13@users.noreply.github.com>
Co-authored-by: JaBeast13 <JaBeast13@users.noreply.github.com>
Co-authored-by: NickKing24 <78986301+NickKing24@users.noreply.github.com>
Co-authored-by: Viyerelu23333 <11363469+Viyerelu23333@users.noreply.github.com>
Co-authored-by: Gitea <gitea@fake.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduling — Filter department dropdown should be in alphabetical order Scheduling — Show sub semesters
3 participants