Moving to vuex #425
Merged
Moving to vuex #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy Link: https://192.155.90.231/ |
|
Tagging @Viyerelu23333 because this will probably have merge conflicts with #410 |
RichtXO
approved these changes
Mar 16, 2021
|
Deploy Link: https://172.104.18.57/ |
|
@123joshuawu Can you fix the CI error? |
|
Ye, I'll open an issue and pr to address |
|
Nvm @RichtXO got it |
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…into moving_to_vuex
|
Deploy Link: https://45.79.133.21/ |
RichtXO
added a commit
that referenced
this pull request
Mar 23, 2021
* First go at issue 373. Moved the Sign Up button into the Log In pop up window * Updated summer2021 to account for partial semesters and update summer2021.csv (#413) * Linked Course Names (#407) * Proposed solution to Issue 387. The course names are now links to course pages. * Created function for finding explore link * Template strings because pretty * beep boop Github Action Master Branch CI Prettier hard at work * Added removed subsmester filter funcionality from #51 (#417) * beep boop Github Action Master Branch CI Prettier hard at work * Updating summer 2021 CSV (#416) * Updating summer 2021 CSV Just updating it periodically * adding fall 2021 * updated courses * updating summer :) * Fixed the spacing between the buttons. Should be good now :) * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updated CSVs (#426) * updated * updated semesters and maybe a fix to the test * just testing * updated * updated csvs * updated * Moving to vuex (#425) * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * beep boop Github Action Master Branch CI Prettier hard at work * First go at issue 373. Moved the Sign Up button into the Log In pop up window * Fixed the spacing between the buttons. Should be good now :) Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com> Co-authored-by: I'm a Github Action <beepboop@github.com> Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joshua Wu <joshuawu3@gmail.com>
RichtXO
added a commit
that referenced
this pull request
Apr 8, 2021
* Update ColorService.js * Update ColorService.js * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updated CSVs (#426) * updated * updated semesters and maybe a fix to the test * just testing * updated * updated csvs * updated * Moving to vuex (#425) * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * beep boop Github Action Master Branch CI Prettier hard at work * Dark mode visibility (#423) * Update CourseListing.vue Update importance of color scheme * Update dark.scss Update button colors * Update dark.scss corrected line that was used for debugging * Update dark.scss Added component for hovering over course boxes * Update SubjectExplorer.vue Fixed hovering color switch (prev when you hovered over course box color did not switch) * Update SubjectExplorer.vue Slight color modification (to match other hover colors) * Update dark.scss comment cleanup * Updating summer 2021 CSV (#416) * Updating summer 2021 CSV Just updating it periodically * adding fall 2021 * updated courses * updating summer :) * Update CourseListing.vue bug fix for clicking prerequisites course (prev forced back to light mode) * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updated CSVs (#426) * updated * updated semesters and maybe a fix to the test * just testing * updated * updated csvs * updated * Update CourseListing.vue Update importance of color scheme * Update dark.scss Update button colors * Update dark.scss corrected line that was used for debugging * Update dark.scss Added component for hovering over course boxes * Update SubjectExplorer.vue Fixed hovering color switch (prev when you hovered over course box color did not switch) * Update SubjectExplorer.vue Slight color modification (to match other hover colors) * Update dark.scss comment cleanup * Update CourseListing.vue bug fix for clicking prerequisites course (prev forced back to light mode) Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move Sign Up Button (#411) * First go at issue 373. Moved the Sign Up button into the Log In pop up window * Updated summer2021 to account for partial semesters and update summer2021.csv (#413) * Linked Course Names (#407) * Proposed solution to Issue 387. The course names are now links to course pages. * Created function for finding explore link * Template strings because pretty * beep boop Github Action Master Branch CI Prettier hard at work * Added removed subsmester filter funcionality from #51 (#417) * beep boop Github Action Master Branch CI Prettier hard at work * Updating summer 2021 CSV (#416) * Updating summer 2021 CSV Just updating it periodically * adding fall 2021 * updated courses * updating summer :) * Fixed the spacing between the buttons. Should be good now :) * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updated CSVs (#426) * updated * updated semesters and maybe a fix to the test * just testing * updated * updated csvs * updated * Moving to vuex (#425) * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * beep boop Github Action Master Branch CI Prettier hard at work * First go at issue 373. Moved the Sign Up button into the Log In pop up window * Fixed the spacing between the buttons. Should be good now :) Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com> Co-authored-by: I'm a Github Action <beepboop@github.com> Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joshua Wu <joshuawu3@gmail.com> * beep boop Github Action Master Branch CI Prettier hard at work * Bump lxml from 4.6.2 to 4.6.3 in /tests (#430) Bumps [lxml](https://github.com/lxml/lxml) from 4.6.2 to 4.6.3. - [Release notes](https://github.com/lxml/lxml/releases) - [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt) - [Commits](lxml/lxml@lxml-4.6.2...lxml-4.6.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump pyyaml from 5.3.1 to 5.4 in /tests (#434) Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.3.1 to 5.4. - [Release notes](https://github.com/yaml/pyyaml/releases) - [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES) - [Commits](yaml/pyyaml@5.3.1...5.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update ColorService.js * Update ColorService.js * Update ColorService.js * Update ColorService.js Co-authored-by: JaBeast13 <JaBeast13@users.noreply.github.com> Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joshua Wu <joshuawu3@gmail.com> Co-authored-by: I'm a Github Action <beepboop@github.com> Co-authored-by: keerti-sundaram <70778626+keerti-sundaram@users.noreply.github.com> Co-authored-by: Nicole Marie Gizzo <gizzon@rpi.edu> Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com>
RichtXO
added a commit
that referenced
this pull request
Apr 15, 2021
* adding 404 page :) * Updated CSVs (#426) * updated * updated semesters and maybe a fix to the test * just testing * updated * updated csvs * updated * Moving to vuex (#425) * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * beep boop Github Action Master Branch CI Prettier hard at work * Dark mode visibility (#423) * Update CourseListing.vue Update importance of color scheme * Update dark.scss Update button colors * Update dark.scss corrected line that was used for debugging * Update dark.scss Added component for hovering over course boxes * Update SubjectExplorer.vue Fixed hovering color switch (prev when you hovered over course box color did not switch) * Update SubjectExplorer.vue Slight color modification (to match other hover colors) * Update dark.scss comment cleanup * Updating summer 2021 CSV (#416) * Updating summer 2021 CSV Just updating it periodically * adding fall 2021 * updated courses * updating summer :) * Update CourseListing.vue bug fix for clicking prerequisites course (prev forced back to light mode) * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updated CSVs (#426) * updated * updated semesters and maybe a fix to the test * just testing * updated * updated csvs * updated * Update CourseListing.vue Update importance of color scheme * Update dark.scss Update button colors * Update dark.scss corrected line that was used for debugging * Update dark.scss Added component for hovering over course boxes * Update SubjectExplorer.vue Fixed hovering color switch (prev when you hovered over course box color did not switch) * Update SubjectExplorer.vue Slight color modification (to match other hover colors) * Update dark.scss comment cleanup * Update CourseListing.vue bug fix for clicking prerequisites course (prev forced back to light mode) Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move Sign Up Button (#411) * First go at issue 373. Moved the Sign Up button into the Log In pop up window * Updated summer2021 to account for partial semesters and update summer2021.csv (#413) * Linked Course Names (#407) * Proposed solution to Issue 387. The course names are now links to course pages. * Created function for finding explore link * Template strings because pretty * beep boop Github Action Master Branch CI Prettier hard at work * Added removed subsmester filter funcionality from #51 (#417) * beep boop Github Action Master Branch CI Prettier hard at work * Updating summer 2021 CSV (#416) * Updating summer 2021 CSV Just updating it periodically * adding fall 2021 * updated courses * updating summer :) * Fixed the spacing between the buttons. Should be good now :) * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updated CSVs (#426) * updated * updated semesters and maybe a fix to the test * just testing * updated * updated csvs * updated * Moving to vuex (#425) * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * beep boop Github Action Master Branch CI Prettier hard at work * First go at issue 373. Moved the Sign Up button into the Log In pop up window * Fixed the spacing between the buttons. Should be good now :) Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com> Co-authored-by: I'm a Github Action <beepboop@github.com> Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joshua Wu <joshuawu3@gmail.com> * beep boop Github Action Master Branch CI Prettier hard at work * adding 404 page :) * Fixed some things * Bump lxml from 4.6.2 to 4.6.3 in /tests (#430) Bumps [lxml](https://github.com/lxml/lxml) from 4.6.2 to 4.6.3. - [Release notes](https://github.com/lxml/lxml/releases) - [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt) - [Commits](lxml/lxml@lxml-4.6.2...lxml-4.6.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * adding an easter egg :] * edit egg to fix all devices not pretty, prob would anger everyone, but it works :))) * Bump pyyaml from 5.3.1 to 5.4 in /tests (#434) Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.3.1 to 5.4. - [Release notes](https://github.com/yaml/pyyaml/releases) - [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES) - [Commits](yaml/pyyaml@5.3.1...5.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix added course to removeCourseSection event (#435) * updated * Auto update prod fall 2021 courses every hour (#436) * Add workflow to update prod courses * test run on current branch * Add python setup * run on ubuntu latest * Set working-direction for upload * Update every hour. Reduce class cache to an hour * Make semester publicly visible * Rename to Semester Data Update * Bump y18n from 4.0.0 to 4.0.1 in /tests/integration (#438) Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * typo fix for id (#439) * title fixed and keywords smol refactor (#441) * beep boop Github Action Master Branch CI Prettier hard at work * Update ColorService.js (#421) * Update ColorService.js * Update ColorService.js * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updated CSVs (#426) * updated * updated semesters and maybe a fix to the test * just testing * updated * updated csvs * updated * Moving to vuex (#425) * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * beep boop Github Action Master Branch CI Prettier hard at work * Dark mode visibility (#423) * Update CourseListing.vue Update importance of color scheme * Update dark.scss Update button colors * Update dark.scss corrected line that was used for debugging * Update dark.scss Added component for hovering over course boxes * Update SubjectExplorer.vue Fixed hovering color switch (prev when you hovered over course box color did not switch) * Update SubjectExplorer.vue Slight color modification (to match other hover colors) * Update dark.scss comment cleanup * Updating summer 2021 CSV (#416) * Updating summer 2021 CSV Just updating it periodically * adding fall 2021 * updated courses * updating summer :) * Update CourseListing.vue bug fix for clicking prerequisites course (prev forced back to light mode) * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updated CSVs (#426) * updated * updated semesters and maybe a fix to the test * just testing * updated * updated csvs * updated * Update CourseListing.vue Update importance of color scheme * Update dark.scss Update button colors * Update dark.scss corrected line that was used for debugging * Update dark.scss Added component for hovering over course boxes * Update SubjectExplorer.vue Fixed hovering color switch (prev when you hovered over course box color did not switch) * Update SubjectExplorer.vue Slight color modification (to match other hover colors) * Update dark.scss comment cleanup * Update CourseListing.vue bug fix for clicking prerequisites course (prev forced back to light mode) Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move Sign Up Button (#411) * First go at issue 373. Moved the Sign Up button into the Log In pop up window * Updated summer2021 to account for partial semesters and update summer2021.csv (#413) * Linked Course Names (#407) * Proposed solution to Issue 387. The course names are now links to course pages. * Created function for finding explore link * Template strings because pretty * beep boop Github Action Master Branch CI Prettier hard at work * Added removed subsmester filter funcionality from #51 (#417) * beep boop Github Action Master Branch CI Prettier hard at work * Updating summer 2021 CSV (#416) * Updating summer 2021 CSV Just updating it periodically * adding fall 2021 * updated courses * updating summer :) * Fixed the spacing between the buttons. Should be good now :) * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updated CSVs (#426) * updated * updated semesters and maybe a fix to the test * just testing * updated * updated csvs * updated * Moving to vuex (#425) * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * beep boop Github Action Master Branch CI Prettier hard at work * First go at issue 373. Moved the Sign Up button into the Log In pop up window * Fixed the spacing between the buttons. Should be good now :) Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com> Co-authored-by: I'm a Github Action <beepboop@github.com> Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joshua Wu <joshuawu3@gmail.com> * beep boop Github Action Master Branch CI Prettier hard at work * Bump lxml from 4.6.2 to 4.6.3 in /tests (#430) Bumps [lxml](https://github.com/lxml/lxml) from 4.6.2 to 4.6.3. - [Release notes](https://github.com/lxml/lxml/releases) - [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt) - [Commits](lxml/lxml@lxml-4.6.2...lxml-4.6.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump pyyaml from 5.3.1 to 5.4 in /tests (#434) Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.3.1 to 5.4. - [Release notes](https://github.com/yaml/pyyaml/releases) - [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES) - [Commits](yaml/pyyaml@5.3.1...5.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update ColorService.js * Update ColorService.js * Update ColorService.js * Update ColorService.js Co-authored-by: JaBeast13 <JaBeast13@users.noreply.github.com> Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joshua Wu <joshuawu3@gmail.com> Co-authored-by: I'm a Github Action <beepboop@github.com> Co-authored-by: keerti-sundaram <70778626+keerti-sundaram@users.noreply.github.com> Co-authored-by: Nicole Marie Gizzo <gizzon@rpi.edu> Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com> * Color blind assist (#440) * Added color blind friendly colors * Added color blind assistance toggle * Color blind assistance cookie * Changed course link color to black * beep boop Github Action Master Branch CI Prettier hard at work * adding the overflow tag * adding 404 page :) * Fixed some things * adding an easter egg :] * edit egg to fix all devices not pretty, prob would anger everyone, but it works :))) * adding the overflow tag * small change Co-authored-by: Joshua Wu <joshuawu3@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: I'm a Github Action <beepboop@github.com> Co-authored-by: keerti-sundaram <70778626+keerti-sundaram@users.noreply.github.com> Co-authored-by: Nicole Marie Gizzo <gizzon@rpi.edu> Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com> Co-authored-by: Jacob Shomstein <jacob@shomstein.com> Co-authored-by: JaBeast13 <78986694+JaBeast13@users.noreply.github.com> Co-authored-by: JaBeast13 <JaBeast13@users.noreply.github.com> Co-authored-by: NickKing24 <78986301+NickKing24@users.noreply.github.com>
RichtXO
added a commit
that referenced
this pull request
May 1, 2021
* Adding Lighthouse audit Was just thinking of automating this process * made changes what's docker again? * run plz? * cert errors have returned to bite my ass... * combining the temp_deploy with the CI * dam it * add seed data * will it work now? * just want to see it work :/ * more changes for the data * changes * changes * what is it outputtng... * sleep? * remove space * finally done! * run this in desktop? * now it should work * adding screenEmulation * test... * test * adding back the desktop * Now Adding 404 Page! (#429) * adding 404 page :) * Updated CSVs (#426) * updated * updated semesters and maybe a fix to the test * just testing * updated * updated csvs * updated * Moving to vuex (#425) * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * beep boop Github Action Master Branch CI Prettier hard at work * Dark mode visibility (#423) * Update CourseListing.vue Update importance of color scheme * Update dark.scss Update button colors * Update dark.scss corrected line that was used for debugging * Update dark.scss Added component for hovering over course boxes * Update SubjectExplorer.vue Fixed hovering color switch (prev when you hovered over course box color did not switch) * Update SubjectExplorer.vue Slight color modification (to match other hover colors) * Update dark.scss comment cleanup * Updating summer 2021 CSV (#416) * Updating summer 2021 CSV Just updating it periodically * adding fall 2021 * updated courses * updating summer :) * Update CourseListing.vue bug fix for clicking prerequisites course (prev forced back to light mode) * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updated CSVs (#426) * updated * updated semesters and maybe a fix to the test * just testing * updated * updated csvs * updated * Update CourseListing.vue Update importance of color scheme * Update dark.scss Update button colors * Update dark.scss corrected line that was used for debugging * Update dark.scss Added component for hovering over course boxes * Update SubjectExplorer.vue Fixed hovering color switch (prev when you hovered over course box color did not switch) * Update SubjectExplorer.vue Slight color modification (to match other hover colors) * Update dark.scss comment cleanup * Update CourseListing.vue bug fix for clicking prerequisites course (prev forced back to light mode) Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move Sign Up Button (#411) * First go at issue 373. Moved the Sign Up button into the Log In pop up window * Updated summer2021 to account for partial semesters and update summer2021.csv (#413) * Linked Course Names (#407) * Proposed solution to Issue 387. The course names are now links to course pages. * Created function for finding explore link * Template strings because pretty * beep boop Github Action Master Branch CI Prettier hard at work * Added removed subsmester filter funcionality from #51 (#417) * beep boop Github Action Master Branch CI Prettier hard at work * Updating summer 2021 CSV (#416) * Updating summer 2021 CSV Just updating it periodically * adding fall 2021 * updated courses * updating summer :) * Fixed the spacing between the buttons. Should be good now :) * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updated CSVs (#426) * updated * updated semesters and maybe a fix to the test * just testing * updated * updated csvs * updated * Moving to vuex (#425) * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * beep boop Github Action Master Branch CI Prettier hard at work * First go at issue 373. Moved the Sign Up button into the Log In pop up window * Fixed the spacing between the buttons. Should be good now :) Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com> Co-authored-by: I'm a Github Action <beepboop@github.com> Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joshua Wu <joshuawu3@gmail.com> * beep boop Github Action Master Branch CI Prettier hard at work * adding 404 page :) * Fixed some things * Bump lxml from 4.6.2 to 4.6.3 in /tests (#430) Bumps [lxml](https://github.com/lxml/lxml) from 4.6.2 to 4.6.3. - [Release notes](https://github.com/lxml/lxml/releases) - [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt) - [Commits](lxml/lxml@lxml-4.6.2...lxml-4.6.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * adding an easter egg :] * edit egg to fix all devices not pretty, prob would anger everyone, but it works :))) * Bump pyyaml from 5.3.1 to 5.4 in /tests (#434) Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.3.1 to 5.4. - [Release notes](https://github.com/yaml/pyyaml/releases) - [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES) - [Commits](yaml/pyyaml@5.3.1...5.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix added course to removeCourseSection event (#435) * updated * Auto update prod fall 2021 courses every hour (#436) * Add workflow to update prod courses * test run on current branch * Add python setup * run on ubuntu latest * Set working-direction for upload * Update every hour. Reduce class cache to an hour * Make semester publicly visible * Rename to Semester Data Update * Bump y18n from 4.0.0 to 4.0.1 in /tests/integration (#438) Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * typo fix for id (#439) * title fixed and keywords smol refactor (#441) * beep boop Github Action Master Branch CI Prettier hard at work * Update ColorService.js (#421) * Update ColorService.js * Update ColorService.js * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updated CSVs (#426) * updated * updated semesters and maybe a fix to the test * just testing * updated * updated csvs * updated * Moving to vuex (#425) * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * beep boop Github Action Master Branch CI Prettier hard at work * Dark mode visibility (#423) * Update CourseListing.vue Update importance of color scheme * Update dark.scss Update button colors * Update dark.scss corrected line that was used for debugging * Update dark.scss Added component for hovering over course boxes * Update SubjectExplorer.vue Fixed hovering color switch (prev when you hovered over course box color did not switch) * Update SubjectExplorer.vue Slight color modification (to match other hover colors) * Update dark.scss comment cleanup * Updating summer 2021 CSV (#416) * Updating summer 2021 CSV Just updating it periodically * adding fall 2021 * updated courses * updating summer :) * Update CourseListing.vue bug fix for clicking prerequisites course (prev forced back to light mode) * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updated CSVs (#426) * updated * updated semesters and maybe a fix to the test * just testing * updated * updated csvs * updated * Update CourseListing.vue Update importance of color scheme * Update dark.scss Update button colors * Update dark.scss corrected line that was used for debugging * Update dark.scss Added component for hovering over course boxes * Update SubjectExplorer.vue Fixed hovering color switch (prev when you hovered over course box color did not switch) * Update SubjectExplorer.vue Slight color modification (to match other hover colors) * Update dark.scss comment cleanup * Update CourseListing.vue bug fix for clicking prerequisites course (prev forced back to light mode) Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move Sign Up Button (#411) * First go at issue 373. Moved the Sign Up button into the Log In pop up window * Updated summer2021 to account for partial semesters and update summer2021.csv (#413) * Linked Course Names (#407) * Proposed solution to Issue 387. The course names are now links to course pages. * Created function for finding explore link * Template strings because pretty * beep boop Github Action Master Branch CI Prettier hard at work * Added removed subsmester filter funcionality from #51 (#417) * beep boop Github Action Master Branch CI Prettier hard at work * Updating summer 2021 CSV (#416) * Updating summer 2021 CSV Just updating it periodically * adding fall 2021 * updated courses * updating summer :) * Fixed the spacing between the buttons. Should be good now :) * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updated CSVs (#426) * updated * updated semesters and maybe a fix to the test * just testing * updated * updated csvs * updated * Moving to vuex (#425) * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists * fixed the CI problem (#427) * Signed-off-by: dependabot[bot] <support@github.com> (#428) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move selectedSemester, courses, semesters, departments, subsemesters into vuex * Add isLoadingCourses vuex state * Add check for courseObj in course page * Default empty schedule for schedule controller * Add route guard to student routes to load semester * Load student courses on courses change * Only add meta for coursepage if courseObj exists Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * beep boop Github Action Master Branch CI Prettier hard at work * First go at issue 373. Moved the Sign Up button into the Log In pop up window * Fixed the spacing between the buttons. Should be good now :) Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com> Co-authored-by: I'm a Github Action <beepboop@github.com> Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joshua Wu <joshuawu3@gmail.com> * beep boop Github Action Master Branch CI Prettier hard at work * Bump lxml from 4.6.2 to 4.6.3 in /tests (#430) Bumps [lxml](https://github.com/lxml/lxml) from 4.6.2 to 4.6.3. - [Release notes](https://github.com/lxml/lxml/releases) - [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt) - [Commits](lxml/lxml@lxml-4.6.2...lxml-4.6.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump pyyaml from 5.3.1 to 5.4 in /tests (#434) Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.3.1 to 5.4. - [Release notes](https://github.com/yaml/pyyaml/releases) - [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES) - [Commits](yaml/pyyaml@5.3.1...5.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update ColorService.js * Update ColorService.js * Update ColorService.js * Update ColorService.js Co-authored-by: JaBeast13 <JaBeast13@users.noreply.github.com> Co-authored-by: Richard Tsai <RichtXO@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joshua Wu <joshuawu3@gmail.com> Co-authored-by: I'm a Github Action <beepboop@github.com> Co-authored-by: keerti-sundaram <70778626+keerti-sundaram@users.noreply.github.com> Co-authored-by: Nicole Marie Gizzo <gizzon@rpi.edu> Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com> * Color blind assist (#440) * Added color blind friendly colors * Added color blind assistance toggle * Color blind assistance cookie * Changed course link color to black * beep boop Github Action Master Branch CI Prettier hard at work * adding the overflow tag * adding 404 page :) * Fixed some things * adding an easter egg :] * edit egg to fix all devices not pretty, prob would anger everyone, but it works :))) * adding the overflow tag * small change Co-authored-by: Joshua Wu <joshuawu3@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: I'm a Github Action <beepboop@github.com> Co-authored-by: keerti-sundaram <70778626+keerti-sundaram@users.noreply.github.com> Co-authored-by: Nicole Marie Gizzo <gizzon@rpi.edu> Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com> Co-authored-by: Jacob Shomstein <jacob@shomstein.com> Co-authored-by: JaBeast13 <78986694+JaBeast13@users.noreply.github.com> Co-authored-by: JaBeast13 <JaBeast13@users.noreply.github.com> Co-authored-by: NickKing24 <78986301+NickKing24@users.noreply.github.com> * beep boop Github Action Master Branch CI Prettier hard at work * Automatically Switch to Dark Mode (#410) * Feat.: Add dark mode following device color scheme * Fix: Reduce flickers caused by loading courses * Feat.: Add method of change scheme to device color * FIX: Change the implementation of dark mode switch * Fix: Change positions of toaster notifications * Feat.: Change color scheme without refreshing * Fix: Coding style enhancements * Fix: Code readability * Feat.: Add dark mode following device color scheme * Fix: Reduce flickers caused by loading courses * Feat.: Add method of change scheme to device color * FIX: Change the implementation of dark mode switch * Fix: Change positions of toaster notifications * Feat.: Change color scheme without refreshing * Fix: Coding style enhancements * Fix: Code readability * Fix: Resolved conflicts * fix: code duplicates and fix cookie reset function Co-authored-by: Gitea <gitea@fake.local> * beep boop Github Action Master Branch CI Prettier hard at work * Nginx cache Solution (#424) * nginx cache solution idk if this would work, but its a test! * changed apt to apt-get * hopefully this works :) * Re-enable caching for JS and CSS files and Brotli * caching json to 5mins * a * updating * block certain user agent * nginx cache solution idk if this would work, but its a test! * changed apt to apt-get * hopefully this works :) * Re-enable caching for JS and CSS files and Brotli * caching json to 5mins * a * updating * block certain user agent * removing brotli, gzip might be better * changed micro_cache to last 1 hour * changing some things * made changes (and idk what prompt the force push) * nginx cache solution idk if this would work, but its a test! * changed apt to apt-get * hopefully this works :) * Re-enable caching for JS and CSS files and Brotli * caching json to 5mins * a * updating * block certain user agent * nginx cache solution idk if this would work, but its a test! * changed apt to apt-get * hopefully this works :) * Re-enable caching for JS and CSS files and Brotli * caching json to 5mins * a * updating * block certain user agent * removing brotli, gzip might be better * changed micro_cache to last 1 hour * changing some things * made changes (and idk what prompt the force push) * adding notFoundPage * just updating csv files * PWA Coming to YACS (#432) * adding default pwa-generated files Got to have a YACS image file with all different dimensions. * Too much assets... May need to edit manifest.json * beep boop Github Action Master Branch CI Prettier hard at work * changing background color * linking apple image * Adding Lighthouse audit Was just thinking of automating this process * made changes what's docker again? * run plz? * cert errors have returned to bite my ass... * combining the temp_deploy with the CI * dam it * add seed data * will it work now? * just want to see it work :/ * more changes for the data * changes * changes * what is it outputtng... * sleep? * remove space * finally done! * run this in desktop? * now it should work * adding screenEmulation * test... * test * adding back the desktop * final changes * small syntax difference? * removed useless docker-compose build * seperated the PR CD and CI * name changed * trying out terosh/lighthouse-ci-action * removing spaces * changing back Had to move the lighthouserc.js to the workflow folder for it to work, and dont want to do that. Also, using the treosh action just takes some thing out of the js file anyway, and having all lighthouse config stuff in 1 file is better to manage * adding url * adding url * Revert "name changed" This reverts commit 30a9086. * asdf * Revert "asdf" This reverts commit e08c0f4. * Revert "Revert "name changed"" This reverts commit 0a33b1b. * Revert "adding url" This reverts commit 95b85ab. * Revert "adding url" This reverts commit b7d044f. * Revert "changing back" This reverts commit 0998119. * Revert "removing spaces" This reverts commit e67bb7e. * Revert "trying out terosh/lighthouse-ci-action" This reverts commit dbbdbf3. Co-authored-by: Joshua Wu <joshuawu3@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: I'm a Github Action <beepboop@github.com> Co-authored-by: keerti-sundaram <70778626+keerti-sundaram@users.noreply.github.com> Co-authored-by: Nicole Marie Gizzo <gizzon@rpi.edu> Co-authored-by: Daniel Ackermans <35609442+marchdan@users.noreply.github.com> Co-authored-by: Jacob Shomstein <jacob@shomstein.com> Co-authored-by: JaBeast13 <78986694+JaBeast13@users.noreply.github.com> Co-authored-by: JaBeast13 <JaBeast13@users.noreply.github.com> Co-authored-by: NickKing24 <78986301+NickKing24@users.noreply.github.com> Co-authored-by: Viyerelu23333 <11363469+Viyerelu23333@users.noreply.github.com> Co-authored-by: Gitea <gitea@fake.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #419
Closes #404
Closes #384
Closes #343
Database Changes/Migrations
N/A
Test Modifications
N/A
Test Procedure
Do anything and nothing should break
Photos
N/A
Additional Info
This PR is to consolidate the scattered state variables into vuex. So we're talking
subsemesters,courses,departments,semesters. In the future, the student course selection and some other things will need to be moved as well but we'll save that for later.This should fix some of the issues arising from state conflicts.
One thing to note is that semester changes no longer go through the router, it is entirely done within vuex. This essentially deprecates the use of the query string semester option for CourseScheduler. I've left the functionality in for now for backwards compatibility, it will work on initial load, but any subsequent semester changes will not be reflected by the query string.
The benefit to this is all components are able to access the same
selectedSemesterstate. This means Explore and CourseScheduler pages are all utilizing the sameselectedSemesterandcoursesstate. So any semester changes will update both accordingly.One final note is the use of the navigation guard for
Studentroutes to load the default semester. On initial load, because the user is navigating to the page for the first time, while the navigation guard is executing, the user will be presented with a blank page. Ideally, the navigation guard logic should run almost immediately and not be erroneous. However, the best solution would be to implement 1) a loading screen for the initial navigation guard and 2) an error screen in case the initial navigation guard fails.