Animated collapse #672
Merged
Animated collapse #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the hide and open button for the side menu
Added the close sidebar function and after the sidebar is closed the schedule image expended to the full screen. Also after the sidebar is closed new button called "Open" appears and if we click it the sidebar opens again.
Please work
|
Love the feature and how useful it is but when it is in dark mode, the arrows to pull out that tab are difficult to see. You can make it a different color maybe blue. It feels like there is a slight delay when closing and opening the tab unless that is intended. |
|
Fixed the color, followed by the scheme. It is clearly visible when dark mode is on now. |
zhangn7
previously approved these changes
Mar 31, 2023
mlammon11
suggested changes
Mar 31, 2023
There was a problem hiding this comment.
Changes from before were mended. However, I see that the color of the course list on light mode is blue, which is a bit hard on the eyes, maybe change it back to black like it currently is. Additionally, I believe that the default action of clicking on the schedule tab is to have the course search on the left instead of automatically closing it.
Defalt status of sidebar is now 'open'
Animatino is now rotating for only Y-axis
|
Finalized animation, and color scheme.
|
mlammon11
previously approved these changes
Apr 7, 2023
chavab0809
previously approved these changes
Apr 7, 2023
* Creating Contribution Guide (#644) This merge is a test to see if Lighthouse CI is being honest to us or not Co-authored-by: dorian451 <112524240+dorian451@users.noreply.github.com> * Fix docker (#655) * Update requirements.txt * Update requirements.txt * Color Mode Button/Notification -Changed the notification button to a switch -Added brief text in front so user knows function - Moved toast notification to top-center of screen * Delete workspace.xml * Dropdown added drop down to condense all 3 functions of button/moon * Drop Down Funcitonal Drop down logic is now functional, still need to add more styling * Updated Notifications and functions Changed the text and color of notifications. added some logic for functions. currently have one bug where sometimes the first mode clicked is the opposite. * Navbar highlight current page (#632) * add highlight to currently selected page in navbar (this took a lot longer than it should have) * make border thicker * fix navbar only being highlighted on top-level pages * beep boop Github Action Master Branch CI Prettier hard at work * Font and color branch (#625) * Update CourseExplorer.vue Changed the color of the title same ad other pages. * Font_and_color_changed * beep boop Github Action Master Branch CI Prettier hard at work * See if I can't specify sqlAlchemy This is a bad news. Since the localhost Docker appears to require us to specify the version. * remove 2020 data * Updated Toggle Style Logic Believe to have resolved bug, now working as intended. Need to change text color on dark mode so that its more readable * More updates comments to understand logic and other updates * Cleaning up just cleaning up code and testings * New logic update updated function logic to hopefully fix errors * Fixed Dropdown Colors Dark mode hover color changed so that the text is more visible to the user * update to running fall 2023 instead pf spring 2023 * change to get summer class info * fixed a summer address link * Adding Current Item Highlight trying to change background color based on currently selected item * changes explore icon (#661) changes explore icon * beep boop Github Action Master Branch CI Prettier hard at work * Update CourseListing.vue (#667) * beep boop Github Action Master Branch CI Prettier hard at work * Current Mode Selected Feature Update Updated some logic and testing, not fully complete * More updates Still working out logic, changed color to what will most likely be close to final color * Clean up removing unnecessary code * Bump json5 from 2.1.3 to 2.2.3 in /tests/integration (#638) Bumps [json5](https://github.com/json5/json5) from 2.1.3 to 2.2.3. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v2.1.3...v2.2.3) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Working on fixing cookies reworking logic to fix cookie issue not following device theme * Revert "Working on fixing cookies" This reverts commit a27eab5. * Update cookie trying to fix logic to update cookies correctly * Fixed Cookie believed to have fixed cookie issue, atleast it works on my local device * Updating Default Logic changed default logic to toggle follow theme if user gets rid of cookie or its first time loading site * beep boop Github Action Master Branch CI Prettier hard at work * Update ci.yaml --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Harry Tan <32246618+DarknessUnder@users.noreply.github.com> Co-authored-by: dorian451 <112524240+dorian451@users.noreply.github.com> Co-authored-by: Troy-bailan-King <97757033+Troy-bailan-King@users.noreply.github.com> Co-authored-by: Matt Lammon <mlammon11@gmail.com> Co-authored-by: Matt Lammon <91478985+mlammon11@users.noreply.github.com> Co-authored-by: I'm a Github Action <beepboop@github.com> Co-authored-by: charleschae12 <112535899+charleschae12@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Re-review requested because of master -> this merge to avoid some issues |
zhengw5
previously approved these changes
Apr 7, 2023
This reverts commit 3f49f69.
dorian451
approved these changes
Apr 14, 2023
DarknessUnder
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
622
Photos
Additional Info
Collapse button no animated!
Also, the sidebar is animated.