No login parse #885
Merged
No login parse #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or data to our json format.
… just have to output as json.
… of large edits and additions to make it work with my previous code and to maximize performance.
martig7
added
Review Ready!
|
Reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
closes #861. Scrapes SIS and catalog.rpi.edu using beautiful soup and selenium. The full scrape should take ~15 mins depending on how many browser instances you give it. It should be extremely accurate with prerequisites, corequisites, and descriptions now too. Also gets extra information from professor Goldschmidt's website.
Test Procedure
Run no_login.py. Change the parameters in name == "main" to change the term.