Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No login parse #885

Merged
merged 15 commits into from
Nov 5, 2024
+3,797 −1,759

oops.

80d27cd
Select commit
Loading
Failed to load commit list.
Merged

No login parse #885

oops.
80d27cd
Select commit
Loading
Failed to load commit list.
codefactor.io / CodeFactor failed Aug 23, 2024 in 13s

14 issues fixed. 80 issues found.

Annotations

Check notice on line 236 in rpi_data/modules/courses_scraper.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/courses_scraper.py#L236 

String statement has no effect (pointless-string-statement)

Check notice on line 29 in rpi_data/modules/faculty_scrape.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/faculty_scrape.py#L29 

Expression "[professor_links_and_sections.append([link, links_and_sections[i][1]]) for link in future.result()]" is assigned to nothing (expression-not-assigned)

Check notice on line 64 in rpi_data/modules/faculty_scrape.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/faculty_scrape.py#L64 

Expression "[unparsed_professor_branches.append(i) for i in found]" is assigned to nothing (expression-not-assigned)

Check notice on line 248 in rpi_data/modules/no_login.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/no_login.py#L248 

Consider using enumerate instead of iterating with range and len (consider-using-enumerate)

Check notice on line 204 in rpi_data/modules/new_parse.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/new_parse.py#L204 

TODO: Accomodate for colspans different than 2.  (fixme)

Check notice on line 332 in rpi_data/modules/courses_scraper.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/courses_scraper.py#L332 

Expression "[to_check.append(prefix + ' ' + code.replace('X', str(i))) for i in range(0, 10)]" is assigned to nothing (expression-not-assigned)

Check notice on line 74 in rpi_data/modules/new_parse.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/new_parse.py#L74 

Expression "[info.append(i) for i in courses]" is assigned to nothing (expression-not-assigned)

Check notice on line 6 in rpi_data/old/build_semester.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/old/build_semester.py#L6 

Starting a process with a shell: Seems safe, but may be changed in the future, consider rewriting without shell (B605)

Check notice on line 54 in rpi_data/modules/courses_scraper.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/courses_scraper.py#L54 

Expression "[parts.append([]) for _ in range(n)]" is assigned to nothing (expression-not-assigned)

Check notice on line 21 in rpi_data/modules/goldy_parse.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/goldy_parse.py#L21 

String statement has no effect (pointless-string-statement)

Check notice on line 283 in rpi_data/modules/courses_scraper.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/courses_scraper.py#L283 

Expression "[to_check.append(i) for i in j[pathway]['One Of0'].values()]" is assigned to nothing (expression-not-assigned)

Check notice on line 45 in rpi_data/modules/ci_scraper.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/ci_scraper.py#L45 

Expression "[cis.add(i) for i in parsed]" is assigned to nothing (expression-not-assigned)

Check notice on line 49 in rpi_data/modules/courses_scraper.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/courses_scraper.py#L49 

String statement has no effect (pointless-string-statement)

Check notice on line 16 in rpi_data/modules/no_login.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/no_login.py#L16 

String statement has no effect (pointless-string-statement)

Check failure on line 25 in rpi_data/modules/goldy_parse.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/goldy_parse.py#L25 

Call to requests with verify=False disabling SSL certificate checks, security issue. (B501)

Check notice on line 339 in rpi_data/modules/no_login.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/no_login.py#L339 

String statement has no effect (pointless-string-statement)

Check notice on line 223 in rpi_data/modules/no_login.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/no_login.py#L223 

String statement has no effect (pointless-string-statement)

Check warning on line 270 in rpi_data/old/fetch_catalog_course_info.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/old/fetch_catalog_course_info.py#L270 

Using lxml.etree.parse to parse untrusted XML data is known to be vulnerable to XML attacks. Replace lxml.etree.parse with its defusedxml equivalent function. (B320)

Check notice on line 217 in rpi_data/modules/courses_scraper.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/courses_scraper.py#L217 

String statement has no effect (pointless-string-statement)

Check warning on line 226 in rpi_data/old/fetch_catalog_course_info.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/old/fetch_catalog_course_info.py#L226 

Using lxml.etree.parse to parse untrusted XML data is known to be vulnerable to XML attacks. Replace lxml.etree.parse with its defusedxml equivalent function. (B320)

Check notice on line 305 in rpi_data/modules/courses_scraper.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/courses_scraper.py#L305 

Expression "[to_check.append(prefix + ' ' + code.replace('X', str(i))) for i in range(0, 10)]" is assigned to nothing (expression-not-assigned)

Check notice on line 262 in rpi_data/old/fetch_catalog_course_info.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/old/fetch_catalog_course_info.py#L224-L262 

Complex Method

Check notice on line 285 in rpi_data/modules/courses_scraper.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/courses_scraper.py#L285 

Expression "[to_check.append(i) for i in j[pathway]['One Of1'].values()]" is assigned to nothing (expression-not-assigned)

Check notice on line 48 in rpi_data/modules/ci_scraper.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/ci_scraper.py#L48 

String statement has no effect (pointless-string-statement)

Check notice on line 52 in rpi_data/modules/no_login.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/no_login.py#L52 

String statement has no effect (pointless-string-statement)
View more details on codefactor.io