Mobile View rework #897
Open
Mobile View rework #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of mobile view showing course selector at top, I moved it below schedule view.
Made it work with mobile view and made it fit better
Made filter on top in mobile view
dorian451
requested changes
Nov 26, 2024
Made it so you cant scroll screen vertically and removed duplicate schedule navigators.
YACS-RCOS#897 Added final commits to help future developers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fix the mobile view for the YACS pages so it is usable in mobile view.
closes #896
Photos
Before
The sidebar is overlapping with the schedule which makes things hard to see and pushing it to the side.
The color assistance button and export data are not placed on the right and is taking too much unnecessary space.
Filter button pushes professors too far to the right so its hard to read.
After
Moved sidebar to the bottom and removed the open and close sidebar when in mobile view so efficiently use space.
Fixed professor and pathways pages by moving the filter buttons to the top to avoid pushing the info and making it hard to read.
Additional Info
Use ctrl-shift-i and control-shift-m to see mobile view or just move the website to the side