-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-009] 파이어베이스 크래시리틱스 추가 #28
Conversation
파일 추가해서 커밋하는 것으로 해결 |
implementation(platform(app.ModuleDependencies.FIREBASE_BOM)) | ||
implementation(app.ModuleDependencies.FIREBASE_ANALYTICS) | ||
implementation(app.ModuleDependencies.FIREBASE_CRASHLYTICS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 BOM으로 넣어주는 경우 버전 정보도 없고 platform으로 넣어주는 게 DependencyInfo
쪽에 없어서 그냥 이렇게 넣어줬는데 방법이 있을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const val FIREBASE_BOM = "com.google.firebase:firebase-bom:${Versions.FIREBASE_BOM}" | ||
const val FIREBASE_ANALYTICS = "com.google.firebase:firebase-analytics-ktx" | ||
const val FIREBASE_CRASHLYTICS = "com.google.firebase:firebase-crashlytics-ktx" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요기도 마찬가지로 같은 이유로 그냥 상수값으로 넣어놨는데 다른 좋은 방법이 있을지,, 의견 여쭤봅니다! ㅠ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 시도해봤는데 따로 넣으려면 아무래도 메소드같은걸 몇 개 더 추가해야 할 것 같은데..
개인적으로는 필요하지 않은 비용? 같기도 해서 나중에 이런 케이스가 한번 더 나오게 되면 그 때 추가하는게 맞는 것 같아용!
지금은 이대로 가도 괜찮을 것 같다는게 제 생각임니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jihee-dev @hoyahozz
버전없는 Data Class 만들어서 따로 주입해보기 해봤는데..
어림없네요 ㅋㅋㅋㅋㅋ
더 찾아봐야 할 것 같아요 방법이 있는지
일단 이렇게 가고 정호님 말씀대로 더 추가하게 되면 바꿔보죠
고생하셨습니다!
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㅋㅋㅋㅋㅋㅋㅋ 넴 빌드 실패한 거 수정해서 머지할게용
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
ISSUE
작업 내용
google-service.json
파일은 Growth 노션에 업로드 완료(브랜치 당겨온 뒤에 앱 수준 디렉토리에 해당 파일을 다운받아 옮겨 주세요!)실행 화면
Check List
[TICKET-{N}] PR 제목
으로 작성