-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-009] 파이어베이스 크래시리틱스 추가 #28
Changes from all commits
18c9ae1
ab0ec77
e01473f
2b52ca1
6c34df3
1080283
b8b05b5
c9a67ab
bf5881f
2121de3
6a7471d
0bd2c2a
d04dea9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
{ | ||
"project_info": { | ||
"project_number": "626079185695", | ||
"project_id": "planz-82728", | ||
"storage_bucket": "planz-82728.appspot.com" | ||
}, | ||
"client": [ | ||
{ | ||
"client_info": { | ||
"mobilesdk_app_id": "1:626079185695:android:a0c32837fa7d87257cce2a", | ||
"android_client_info": { | ||
"package_name": "com.yapp.growth" | ||
} | ||
}, | ||
"oauth_client": [ | ||
{ | ||
"client_id": "626079185695-j6kgiofc8h8tqh8gu8talv5c1soq866s.apps.googleusercontent.com", | ||
"client_type": 3 | ||
} | ||
], | ||
"api_key": [ | ||
{ | ||
"current_key": "AIzaSyAyx8MnwBiLESMNMhh0yARVCWxWkBiIs9U" | ||
} | ||
], | ||
"services": { | ||
"appinvite_service": { | ||
"other_platform_oauth_client": [ | ||
{ | ||
"client_id": "626079185695-j6kgiofc8h8tqh8gu8talv5c1soq866s.apps.googleusercontent.com", | ||
"client_type": 3 | ||
} | ||
] | ||
} | ||
} | ||
} | ||
], | ||
"configuration_version": "1" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,22 @@ | ||
// alphabet 순서대로 정렬 | ||
object Versions { | ||
const val ANDROID_APP_COMPAT = "1.4.1" | ||
const val ANDROID_BUILD_TOOL = "7.2.0" | ||
const val ANDROID_CORE = "1.7.0" | ||
const val KOTLIN = "1.6.10" | ||
const val COMPOSE = "1.1.1" | ||
const val ACTIVITY_COMPOSE = "1.4.0" | ||
const val ANDROID_APP_COMPAT = "1.4.1" | ||
const val CONSTRAINT_LAYOUT = "2.1.3" | ||
const val COIL = "1.4.0" | ||
const val LIFECYCLE = "2.4.1" | ||
const val COMPOSE = "1.2.0-alpha08" | ||
const val COMPOSE_ACTIVITY = "1.4.0" | ||
const val CONSTRAINT_LAYOUT = "2.1.3" | ||
const val FIREBASE_BOM = "29.1.0" | ||
const val FIREBASE_CRASHLYTICS = "2.9.0" | ||
const val GOOGLE_SERVICE = "4.3.10" | ||
const val HILT = "2.42" | ||
const val HILT_ANDROID = "1.0.0-beta01" | ||
const val JUNIT = "4.13.2" | ||
const val KOTLIN = "1.6.20" | ||
const val KOTLIN_COROUTINES = "1.5.1" | ||
const val RETROFIT = "2.7.1" | ||
const val LIFECYCLE = "2.4.1" | ||
const val OKHTTP = "4.3.1" | ||
const val HILT = "2.42" | ||
const val HILT_ANDROID = "1.0.0-beta01" | ||
const val RETROFIT = "2.7.1" | ||
const val TIMBER = "5.0.1" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,7 +63,7 @@ object ModuleDependencies { | |
), | ||
DependencyInfo( | ||
"androidx.activity:activity-compose", | ||
Versions.ACTIVITY_COMPOSE, | ||
Versions.COMPOSE_ACTIVITY, | ||
Method.IMPLEMENTATION | ||
), | ||
DependencyInfo("io.coil-kt:coil-compose", Versions.COIL, Method.IMPLEMENTATION) | ||
|
@@ -121,8 +121,12 @@ object ModuleDependencies { | |
Method.IMPLEMENTATION | ||
), | ||
) | ||
|
||
val timber = arrayOf( | ||
DependencyInfo("com.jakewharton.timber:timber", Versions.TIMBER, Method.IMPLEMENTATION) | ||
) | ||
|
||
const val FIREBASE_BOM = "com.google.firebase:firebase-bom:${Versions.FIREBASE_BOM}" | ||
const val FIREBASE_ANALYTICS = "com.google.firebase:firebase-analytics-ktx" | ||
const val FIREBASE_CRASHLYTICS = "com.google.firebase:firebase-crashlytics-ktx" | ||
Comment on lines
+129
to
+131
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 요기도 마찬가지로 같은 이유로 그냥 상수값으로 넣어놨는데 다른 좋은 방법이 있을지,, 의견 여쭤봅니다! ㅠ There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 저도 시도해봤는데 따로 넣으려면 아무래도 메소드같은걸 몇 개 더 추가해야 할 것 같은데.. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jihee-dev @hoyahozz 어림없네요 ㅋㅋㅋㅋㅋ 일단 이렇게 가고 정호님 말씀대로 더 추가하게 되면 바꿔보죠 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ㅋㅋㅋㅋㅋㅋㅋ 넴 빌드 실패한 거 수정해서 머지할게용 |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 BOM으로 넣어주는 경우 버전 정보도 없고 platform으로 넣어주는 게
DependencyInfo
쪽에 없어서 그냥 이렇게 넣어줬는데 방법이 있을까요?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
platform 이라는 워딩이 있긴 한데.. 어떻게 쓰는건지를 모르겠네요 저도 더 시도해볼게요