[ISSUE-61] 약속 공유하기 UI 및 카카오톡 공유 기능을 구현합니다 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- UI 구현 - 링크 복사 기능 구현 - 카카오톡 공유하기 임시 구현
- 네비게이션 구현 - 카카오톡 공유하기 intent 처리
- secrets 라이브러리를 통해서 BuildConfig 생성
- 서버로부터 이미지 받아오도록 수정 - 이미지 크기 조정 - 디자인 수정
…hare-plan-ui # Conflicts: # data/src/main/java/com/yapp/growth/data/di/DataModule.kt # presentation/build.gradle.kts # presentation/src/main/java/com/yapp/growth/presentation/ui/createPlan/CreatePlanScreen.kt # presentation/src/main/res/values/strings.xml
KwonDae
approved these changes
Jul 18, 2022
presentation/build.gradle.kts
Outdated
| @@ -46,6 +47,7 @@ dependencies { | |||
| app.ModuleDependencies.materialCalendarView.implement(this) | |||
| app.ModuleDependencies.accompanist.implement(this) | |||
| app.ModuleDependencies.kotlinDateTime.implement(this) | |||
| app.ModuleDependencies.kakaoSdk.implement(this) // Share 부분만 의존성 추가하는 것이 좋은가..? | |||
There was a problem hiding this comment.
good, better 차이의 느낌일 것 같은데
웬만하면 분리해서 의존성을 추가하는게 나을 것 같습니다
There was a problem hiding this comment.
좋아여 네이밍도 kakaoOauth, kakaoShare로 바꾸고 나눠서 의존성 추가해놓겠습니당
Comment on lines
192
to
202
| runCatching { | ||
| KakaoCustomTabsClient.openWithDefault(context, sharerUrl) | ||
| }.onFailure { | ||
| failToShareWithKakaoTalk() | ||
| } | ||
|
|
||
| runCatching { | ||
| KakaoCustomTabsClient.open(context, sharerUrl) | ||
| }.onFailure { | ||
| failToShareWithKakaoTalk() | ||
| } |
There was a problem hiding this comment.
try-catch 대신 runCatching 으로 onSuccess, onFailure 사용해서 Result 타입으로 관리하는 부분 정말 잘 하셨어요!
runCaching, mapCatching 모두 많이 쓰이는 Api 이므로 잘 익혀놓으시면 쓸일이 많을겁니다
하나 궁금한건 openWithDefault, open 두 메소드 모두 호출되어야 공유하기 탭이 활성화 되는건가요? 공유하기 로직이 어떻게 되는지 몰라서 궁금합니당
There was a problem hiding this comment.
openWithDefault()랑 open() 차이가 CustomTabsServiceConnection을 지원하는 브라우저로 여냐 아니냐의 차이인데
아무래도 둘 중 하나의 방법으로만 열어야 할 것 같네요,,,
다시 확인해서 문제 있는 부분 수정해놓겠습니다!
There was a problem hiding this comment.
확인해 보니 확실히 문제가 있었네요 ㅠㅠ 수정해서 다시 커밋했어요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE
작업 내용
실행 화면
Check List
[ISSUE-{N}] PR 제목으로 작성