-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-61] 약속 공유하기 UI 및 카카오톡 공유 기능을 구현합니다 #98
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9bddc44
chore - 카카오톡 공유 관련 의존성 추가
jihee-dev 9218d44
style - 코드 가독성 향상
jihee-dev 72c5bf0
design - 변경된 폰트 시스템 적용
jihee-dev 9c2ea88
feat - 약속 공유하기 구현
jihee-dev e379654
feat - 네비게이션 구현
jihee-dev f5aa769
design - 디자인 변경사항 적용
jihee-dev b3aa63e
chore - getProperty 함수 삭제
jihee-dev b6592ba
feat - 카카오톡 공유하기 기능 수정
jihee-dev f24bdd3
Merge remote-tracking branch 'origin/develop' into feature/issue-61-s…
jihee-dev c280465
fix - 짧은 시간에 여러 번 스낵바가 띄워질 때 이전 스낵바를 닫은 뒤 띄워지도록 수정
jihee-dev 57e2907
style - string resource 순서 변경
jihee-dev 7108dc4
chore - kakao OAuth, Share dependency 분리
jihee-dev fefb802
fix - 공유하기를 위한 웹 뷰가 두 번 뜨는 문제 수정
jihee-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
presentation/src/main/java/com/yapp/growth/presentation/ui/createPlan/share/ShareContract.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
package com.yapp.growth.presentation.ui.createPlan.share | ||
|
||
import com.yapp.growth.base.ViewEvent | ||
import com.yapp.growth.base.ViewSideEffect | ||
import com.yapp.growth.base.ViewState | ||
|
||
class ShareContract { | ||
data class ShareViewState( | ||
val shareUrl: String = "planz/link/sample/125", // TODO: 공유 URL | ||
val snackBarType: SnackBarType = SnackBarType.SUCCESS, | ||
) : ViewState { | ||
enum class SnackBarType { | ||
SUCCESS, | ||
FAIL | ||
} | ||
} | ||
|
||
sealed class ShareSideEffect : ViewSideEffect { | ||
object FinishCreatePlan : ShareSideEffect() | ||
object CopyShareUrl : ShareSideEffect() | ||
object ShowSuccessSnackBar : ShareSideEffect() | ||
object ShowFailToShareSnackBar : ShareSideEffect() | ||
object SendKakaoShareMessage : ShareSideEffect() | ||
} | ||
|
||
sealed class ShareEvent : ViewEvent { | ||
object OnClickExit : ShareEvent() | ||
object OnClickCopy : ShareEvent() | ||
object OnClickShare : ShareEvent() | ||
object FailToShare : ShareEvent() | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good, better 차이의 느낌일 것 같은데
웬만하면 분리해서 의존성을 추가하는게 나을 것 같습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋아여 네이밍도
kakaoOauth
,kakaoShare
로 바꾸고 나눠서 의존성 추가해놓겠습니당There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
죠습니당