-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making requests_client.py's Authenticator URL matches() port-tolerant #384
Open
myselfhimself
wants to merge
1
commit into
Yelp:master
Choose a base branch
from
myselfhimself:myselfhimself-non-port-tolerant-authenticator-matches
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Making requests_client.py's Authenticator URL matches() port-tolerant #384
myselfhimself
wants to merge
1
commit into
Yelp:master
from
myselfhimself:myselfhimself-non-port-tolerant-authenticator-matches
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authenticator::matches()'s documentation advertises full host, scheme and port match, when it just checks for hosts. However when checking hosts, it cannot compare well a configured self.host:withPort (eg. localhost:8080) with the outgoing request full URL's host. Such a corner case can happen with this piece of code: http_client.set_basic_auth( 'localhost:8080', BASIC_AUTH_LOGIN, BASIC_AUTH_PASSWORD )
Same issue with the set_api_key() method. This makes authenticated bravado requests fail when unit testing on a local server hosted at localhost:8080.. |
⬆️ |
Hello, I am not working on this topic anymore and will not increase the
code coverage of this PR sorry.
Le mar. 26 nov. 2019 à 08:38, Alexander Sapronov <notifications@github.com>
a écrit :
… ⬆️
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#384?email_source=notifications&email_token=AAJU5QX7RWNVQHGOFU2QGOLQVTG7PA5CNFSM4FKZPXCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFFA7MY#issuecomment-558501811>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJU5QX7Y3I5FSUQBA7DNH3QVTG7PANCNFSM4FKZPXCA>
.
|
This has been reworked in the meantime (in #444), and now compares host and port (correctly). Are you able to test with the latest master and confirm that it fixes the issue for you @myselfhimself ? I could then make a release that includes the change. |
Hello,
I am sorry I do not have access to the customer's codebase anymore and have
changed working fields so will not assist in testing more for now :-/
:)
čt 6. 2. 2020 v 9:21 odesílatel Stephan Jaensch <notifications@github.com>
napsal:
… This has been reworked in the meantime (in #444
<#444>), and now compares host and
port (correctly). Are you able to test with the latest master and confirm
that it fixes the issue for you @myselfhimself
<https://github.com/myselfhimself> ? I could then make a release that
includes the change.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#384?email_source=notifications&email_token=AAJU5QUJIMBYSUSYIALZBL3RBPB7VA5CNFSM4FKZPXCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK6KL7Q#issuecomment-582788606>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJU5QURNZGVBU7G32SGS73RBPB7VANCNFSM4FKZPXCA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authenticator::matches()'s documentation advertises full host, scheme and port match, when it just checks for hosts. However when checking hosts, it cannot compare well a configured self.host:withPort (eg. localhost:8080) with the outgoing request full URL's host.
Such a corner case can happen with this piece of code:
http_client.set_basic_auth(
'localhost:8080',
BASIC_AUTH_LOGIN, BASIC_AUTH_PASSWORD
)