Fix header authentication for host:port type #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjaensch
suggested changes
Nov 28, 2019
| @@ -46,7 +46,7 @@ def matches(self, url): | |||
| :return: True if matches host, port and scheme, False otherwise. | |||
| """ | |||
| split = urlparse.urlsplit(url) | |||
| return self.host == split.hostname | |||
| return self.host == split.netloc | |||
There was a problem hiding this comment.
Hey @sanda87, thanks for the PR and sorry for the late response!
While this works in your case, we should also either fix the docstring (we're not checking the scheme), or add that in here as well.
Could you also please add a test to make sure it works as expected, and so that there will be no regressions in the future? Maybe tests/http_client_test.py is a good fit for that.
There was a problem hiding this comment.
Hi @sjaensch ,
I added tests for this case and updated docstring in my new commit
added 2 commits
December 16, 2019 14:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
All our apps work on ports and we found out that bravado doesn't support host:port type for Header Authentication. The pull request adds the support.