Add per line exclude regex via --exclude-line #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 15a6e6a.
Change baseline format to replace `exclude_regex` with
```
"exclude":{
"files": "foo",
"lines": "bar"
}
```
Pass `exclude_lines_re` to all plugins in `from_plugin_classname`
When `scan_diff`, used by `detect-secrets-server` calls `_extract_secrets_from_patch` it uses `plugin.analyze_string`, and we were previously checking whitelist regexes in plugins' `analyze` method. :snake: Change all `_re` suffixes to `_regex` Add a newline in plugins, particularly between class def and secret_type attribute
|
(took feedback into account and fixed a 🐛 that detect-secrets-server triggers 👍 ) |
This was referenced Feb 8, 2019
domanchi
reviewed
Feb 9, 2019
| @@ -39,7 +39,9 @@ class HighEntropyStringsPlugin(BasePlugin): | |||
|
|
|||
| __metaclass__ = ABCMeta | |||
|
|
|||
| def __init__(self, charset, limit, exclude_lines_re, *args): | |||
| secret_type = 'High Entropy String' | |||
There was a problem hiding this comment.
Not necessary -- after all, there shouldn't be a secret_type, seeing that this class cannot (and should not) be constructed directly.
This also checks for it: https://github.com/Yelp/detect-secrets/blob/master/detect_secrets/plugins/base.py#L16
There was a problem hiding this comment.
Ah fair. Probably cause we didn't do a super call.
You can drop the issue. Probably easier this way, than creating a mock base class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this reverts 15a6e6a in favor of a line exclude arg for all plugins. If at a later date we would like a regex specifically for e.g.
KeywordDetector, then we can add that feature then.💥 This removes the
--excludeCLI arg🎉 Replace
--exclude with--exclude-filesand--exclude-lines