Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stretch itest missing "ps" command, use pipefail to catch it earlier in the future #50

Merged
merged 1 commit into from
Jan 7, 2016

Conversation

chriskuehl
Copy link
Contributor

The test was failing but not generating a nonzero status code because pipefail wasn't on.

Previously it looked like this:

+ exec dumb-init /mnt/tests/test-zombies
+ sleep 1
+ bash -euxc 'bash -euxc '\''echo i am a zombie'\'' &'
+ bash -euxc 'echo i am a zombie'
+ echo i am a zombie
i am a zombie
++ ps -A -o state
++ grep Z
/mnt/tests/test-zombies: line 13: ps: command not found
++ wc -l
+ num_zombies=0
+ '[' 0 -ne 0 ']'

Target itest_stretch completed successfully

(stretch is unreleased and something of a moving target, so it's not totally unexpected that something like this might happen -- but obviously the tests should have caught it!)

bukzor pushed a commit that referenced this pull request Jan 7, 2016
Fix stretch itest missing "ps" command, use pipefail to catch it earlier in the future
@bukzor bukzor merged commit 87545be into Yelp:master Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants