Call weight.getQuery().toString() once per query instead of once per …

…leaf (#524)
Yelp · Dec 2, 2022 · cb25af8 · cb25af8
1 parent 829ad04
commit cb25af8
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/main/java/com/yelp/nrtsearch/server/luceneserver/MyIndexSearcher.java b/src/main/java/com/yelp/nrtsearch/server/luceneserver/MyIndexSearcher.java
@@ -239,6 +239,9 @@ public static LeafSlice[] slices(
   @Override
   protected void search(List<LeafReaderContext> leaves, Weight weight, Collector collector)
       throws IOException {
+    boolean isDrillSidewaysQueryOrCompletionQuery =
+        weight.getQuery() instanceof CompletionQuery
+            || weight.getQuery().toString().contains("DrillSidewaysQuery");
     for (LeafReaderContext ctx : leaves) { // search each subreader
       // we force the use of Scorer (not BulkScorer) to make sure
       // that the scorer passed to LeafCollector.setScorer supports
@@ -251,8 +254,7 @@ protected void search(List<LeafReaderContext> leaves, Weight weight, Collector c
         // continue with the following leaf
         continue;
       }
-      if (weight.getQuery().toString().contains("DrillSidewaysQuery")
-          || weight.getQuery() instanceof CompletionQuery) {
+      if (isDrillSidewaysQueryOrCompletionQuery) {
         BulkScorer scorer = weight.bulkScorer(ctx);
         if (scorer != null) {
           try {