Call weight.getQuery().toString() once per query instead of once per leaf #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprudhomme
approved these changes
Dec 2, 2022
|
@aprudhomme agreed. Would be good to confirm if we ever enter that branch other than for completion queries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toStringon a query object can be significantly expensive for large queries. Trying to avoid doing it multiple times for a single query. I also changed the order of the calls so the toString would not be called at all for CompletionQuery.It would be better to avoid calling toString at all....but I couldn't find any test for which
weight.getQuery().toString().contains("DrillSidewaysQuery")is true.