-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update species data location #282
Open
olgabot
wants to merge
1,989
commits into
master
Choose a base branch
from
update_species_data_location
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add requirement for non-plotting examples to be documented as ipython notebooks
Supplemental data
Add supplementaldata to tutorial
…nch is going to be part of documentation
Study save min samples
* 'master' of github.com:YeoLab/flotilla: (81 commits) Add supplementaldata to tutorial Add release notes about documenting Add release notes actually save the minimum number of samples Add finished supplementaldata ipynb Add option and test for user-specified flotilla directory fix pep8 Get supplemental resource name, not name of supplemental fix resource --> supplemental in reading all supplemental data actually iterate over the items of name_to_df Clarify where example plots should go, add requirement for new non-plotting features to be documented as ipython notebooks and added to the tutorial initial addition of ipynb for supplementaldata move _is_absolute_path to not a method of Study because it's needed during _filename_from_resource but can't use non-staticmethod methods on an uninstantiated class Add test for embarking on a datapackage with supplemental data Add supplemental data to reading/loading of the datapackage Add newline to sys.stdout message pep8 fixes add release notes Add release notes lint fixes ...
* master: Add finished supplementaldata ipynb Add option and test for user-specified flotilla directory fix pep8 Get supplemental resource name, not name of supplemental fix resource --> supplemental in reading all supplemental data actually iterate over the items of name_to_df Clarify where example plots should go, add requirement for new non-plotting features to be documented as ipython notebooks and added to the tutorial initial addition of ipynb for supplementaldata move _is_absolute_path to not a method of Study because it's needed during _filename_from_resource but can't use non-staticmethod methods on an uninstantiated class Add test for embarking on a datapackage with supplemental data Add supplemental data to reading/loading of the datapackage Add newline to sys.stdout message pep8 fixes add release notes initial tests of supplemental seem to work initial commit of supplemental data
* modality_priors: Add release notes add modalities ipython notebook to tutorial.rst add ipython notebook fix pep8 errors created by removal of "_fixed" Move installing packages for documentation to only happen if this branch is going to be part of documentation removed _fixed from test_splicingdata fix pep8 Fix tests for modality assignments Add docstrings and set minimum samples to be 10 fix modality priors change min samples to default to 10 instead of 0.5 forgot parens around bimodal model parameters change min_samples to 10 shift bimodal and middle distributions to start with parameters more ddifferent than 1, and make bimodal an exponential prior
…at allows you to only read in hte first nrows of a file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the species data location to https://s3-us-west-2.amazonaws.com/flotilla (which I have access to edit), and fix up the reading of these files to set the first column as the index, and updated the hg19 data to include cell cycle, and more useful things.
Check for code coverage. To run code coverage on only the file you changed,
for example
flotilla/compute/splicing.py
, use this command:py.test --cov flotilla/compute/splicing.py --cov-report term-missing flotilla/test/compute/test_splicing.py
which will show you which lines aren't covered by the tests.
numpydoc
style docstrings?
examples/
, and is that notebook added todoc/tutorial.rst
?If it adds a new plot, is it documented in the gallery, as a.py
filein
examples/
?make pep8
andmake lint
outputchanges were made?