Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update species data location #282

Open
wants to merge 1,989 commits into
base: master
Choose a base branch
from
Open

Conversation

olgabot
Copy link
Collaborator

@olgabot olgabot commented Apr 2, 2015

Update the species data location to https://s3-us-west-2.amazonaws.com/flotilla (which I have access to edit), and fix up the reading of these files to set the first column as the index, and updated the hg19 data to include cell cycle, and more useful things.

  • Is it mergable?
  • Did it pass the tests?
  • If it introduces new functionality in is it tested?
    Check for code coverage. To run code coverage on only the file you changed,
    for example flotilla/compute/splicing.py, use this command:
    py.test --cov flotilla/compute/splicing.py --cov-report term-missing flotilla/test/compute/test_splicing.py
    which will show you which lines aren't covered by the tests.
  • Do the new functions have descriptive
    numpydoc
    style docstrings?
  • If it adds a new feature, is it documented as an IPython Notebook in
    examples/, and is that notebook added to doc/tutorial.rst?
  • If it adds a new plot, is it documented in the gallery, as a .py file
    in examples/?
  • Is it well formatted? Look at make pep8 and make lint output
  • Is it documented in the doc/releases/?
  • Was a spellchecker run on the source code and documentation after
    changes were made?

olgabot and others added 30 commits January 10, 2015 20:49
olgabot added 28 commits March 16, 2015 16:44
Add requirement for non-plotting examples to be documented as ipython notebooks
Add supplementaldata to tutorial
* 'master' of github.com:YeoLab/flotilla: (81 commits)
  Add supplementaldata to tutorial
  Add release notes about documenting
  Add release notes
  actually save the minimum number of samples
  Add finished supplementaldata ipynb
  Add option and test for user-specified flotilla directory
  fix pep8
  Get supplemental resource name, not name of supplemental
  fix resource --> supplemental in reading all supplemental data
  actually iterate over the items of name_to_df
  Clarify where example plots should go, add requirement for new non-plotting features to be documented as ipython notebooks and added to the tutorial
  initial addition of ipynb for supplementaldata
  move _is_absolute_path to not a method of Study because it's needed during _filename_from_resource but can't use non-staticmethod methods on an uninstantiated class
  Add test for embarking on a datapackage with supplemental data
  Add supplemental data to reading/loading of the datapackage
  Add newline to sys.stdout message
  pep8 fixes
  add release notes
  Add release notes
  lint fixes
  ...
* master:
  Add finished supplementaldata ipynb
  Add option and test for user-specified flotilla directory
  fix pep8
  Get supplemental resource name, not name of supplemental
  fix resource --> supplemental in reading all supplemental data
  actually iterate over the items of name_to_df
  Clarify where example plots should go, add requirement for new non-plotting features to be documented as ipython notebooks and added to the tutorial
  initial addition of ipynb for supplementaldata
  move _is_absolute_path to not a method of Study because it's needed during _filename_from_resource but can't use non-staticmethod methods on an uninstantiated class
  Add test for embarking on a datapackage with supplemental data
  Add supplemental data to reading/loading of the datapackage
  Add newline to sys.stdout message
  pep8 fixes
  add release notes
  initial tests of supplemental seem to work
  initial commit of supplemental data
* modality_priors:
  Add release notes
  add modalities ipython notebook to tutorial.rst
  add ipython notebook
  fix pep8 errors created by removal of "_fixed"
  Move installing packages for documentation to only happen if this branch is going to be part of documentation
  removed _fixed from test_splicingdata
  fix pep8
  Fix tests for modality assignments
  Add docstrings and set minimum samples to be 10
  fix modality priors
  change min samples to default to 10 instead of 0.5
  forgot parens around bimodal model parameters
  change min_samples to 10
  shift bimodal and middle distributions to start with parameters more ddifferent than 1, and make bimodal an exponential prior
…at allows you to only read in hte first nrows of a file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants